Skip to content

Commit ad0a38c

Browse files
committed
Make the sanitizing for application metadata case-insensitive
fixes codecentric#590
1 parent 8143743 commit ad0a38c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

spring-boot-admin-server/src/main/java/de/codecentric/boot/admin/model/Application.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ public MetadataSerializer() {
318318
private static Pattern[] createPatterns(String... keys) {
319319
Pattern[] patterns = new Pattern[keys.length];
320320
for (int i = 0; i < keys.length; i++) {
321-
patterns[i] = Pattern.compile(keys[i]);
321+
patterns[i] = Pattern.compile(keys[i], Pattern.CASE_INSENSITIVE);
322322
}
323323
return patterns;
324324
}

spring-boot-admin-server/src/test/java/de/codecentric/boot/admin/model/ApplicationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public void test_healthUrl_expected() throws Exception {
8181
@Test
8282
public void test_sanitize_metadata() throws JsonProcessingException {
8383
Application app = Application.create("test").withHealthUrl("http://health")
84-
.addMetadata("password", "qwertz123").addMetadata("user", "humptydumpty").build();
84+
.addMetadata("PASSWORD", "qwertz123").addMetadata("user", "humptydumpty").build();
8585
String json = objectMapper.writeValueAsString(app);
8686
assertThat(json, not(containsString("qwertz123")));
8787
assertThat(json, containsString("humptydumpty"));

0 commit comments

Comments
 (0)