Batch update at update_many

Author: otoyo

lib/zendesk_api/actions.rb

@@ -276,15 +276,19 @@ def update!(client, attributes = {}, &block)
  module UpdateMany
  # Updates multiple resources using the update_many endpoint.
  # @param [Client] client The {Client} object to be used
- # @param [Array] ids An array of ids to update
+ # @param [Array] ids_or_attributes_array An array of ids or arributes including ids to update
  # @param [Hash] attributes The attributes to update resources with
  # @return [JobStatus] the {JobStatus} instance for this destroy job
- def update_many!(client, ids, attributes)
+ def update_many!(client, ids_or_attributes_array, attributes = {})
  association = attributes.delete(:association) || Association.new(:class => self)
 
  response = client.connection.put("#{association.generate_path}/update_many") do |req|
- req.params = { :ids => ids.join(',') }
- req.body = { singular_resource_name => attributes }
+ if attributes == {}
+ req.body = { resource_name => ids_or_attributes_array }
+ else
+ req.params = { :ids => ids_or_attributes_array.join(',') }
+ req.body = { singular_resource_name => attributes }
+ end
 
  yield req if block_given?
  end

spec/core/bulk_actions_spec.rb

@@ -47,22 +47,44 @@
  subject { ZendeskAPI::BulkTestResource }
 
  context "update_many!" do
- let(:attributes) { { :name => 'A', :age => 25 } }
+ context "arity: 3" do
+ let(:attributes) { { :name => 'A', :age => 25 } }
 
- before(:each) do
- stub_json_request(:put, %r{bulk_test_resources/update_many}, json(:job_status => { :id => 'ghi' }))
- @response = subject.update_many!(client, [1, 2, 3], attributes)
- end
+ before(:each) do
+ stub_json_request(:put, %r{bulk_test_resources/update_many}, json(:job_status => { :id => 'ghi' }))
+ @response = subject.update_many!(client, [1, 2, 3], attributes)
+ end
+
+ it 'calls the update_many endpoint' do
+ assert_requested(:put, %r{bulk_test_resources/update_many\?ids=1,2,3$},
+ :body => json(:bulk_test_resource => attributes)
+ )
+ end
 
- it 'calls the update_many endpoint' do
- assert_requested(:put, %r{bulk_test_resources/update_many\?ids=1,2,3$},
- :body => json(:bulk_test_resource => attributes)
- )
+  it 'returns a JobStatus' do
+  expect(@response).to be_instance_of(ZendeskAPI::JobStatus)
+ expect(@response.id).to eq('ghi')
+ end
  end
 
- it 'returns a JobStatus' do
- expect(@response).to be_instance_of(ZendeskAPI::JobStatus)
- expect(@response.id).to eq('ghi')
+ context "arity: 2" do
+ let(:attributes_array) { [{ :id => 1, :name => 'A' }, { :id => 2, :name => 'B' }] }
+
+ before(:each) do
+ stub_json_request(:put, %r{bulk_test_resources/update_many}, json(:job_status => { :id => 'jkl' }))
+ @response = subject.update_many!(client, attributes_array)
+ end
+
+ it 'calls the update_many endpoint' do
+ assert_requested(:put, %r{bulk_test_resources/update_many$},
+ :body => json(:bulk_test_resources => attributes_array)
+ )
+ end
+
+ it 'returns a JobStatus' do
+ expect(@response).to be_instance_of(ZendeskAPI::JobStatus)
+ expect(@response.id).to eq('jkl')
+ end
  end
  end
  end