Skip to content

Fixed apply discount coupons for bundle product #22987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2019
Merged

Fixed apply discount coupons for bundle product #22987

merged 3 commits into from
Jul 1, 2019

Conversation

@NikolasSumrak
Copy link
Contributor

@NikolasSumrak NikolasSumrak commented May 23, 2019 •
edited
Loading

Fixed apply discount coupons for bundle product with both virtual and simple product and "Ship Bundle Items" = "Separately"

Description (*)

Fix issue: Coupon doesn't work for bundle product
Preconditions:

  1. Magento 2.2.8 Enterprise Edition
  2. Have Bundle item with children:
  • Simple product, default QTY = 1
  • Virtual Product, default QTY = 1
  1. Have Cart Price rule with coupon, some discount (e.g. 10%), with conditions:
    If ANY of these conditions are TRUE :
    If an item is FOUND in the cart with ANY of these conditions true:
    SKU is SKU_OF_BUNDLE_PRODUCT

Steps to reproduce:

  1. Add to cart this Bundle Item
  2. Go to cart page
  3. Apply coupon

Expected Result:
Coupon has been applied

Actual result:
Coupon has not been applied.
Message "Invalid coupon code" shown.

Manual testing scenarios (*)

See Description

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@NikolasSumrak
Fixed apply discount coupons for bundle product
ab83cdb 
Fixed apply discount coupons for bundle product with both virtual and simple product and "Ship Bundle Items" = "Separately"
@m2-assistant
Copy link

m2-assistant bot commented May 23, 2019

Hi @NikolasSumrak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 23, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
orlangur
orlangur requested changes May 26, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NikolasSumrak,

I'm not sure such logic wasn't intentional, please write an integration test covering described case.
@ghost ghost assigned orlangur May 26, 2019
@Nazar65 Nazar65 assigned Nazar65 and unassigned Nazar65 Jun 6, 2019
@engcom-Golf engcom-Golf self-assigned this Jun 20, 2019
@engcom-Golf
Copy link
Contributor

engcom-Golf commented Jun 20, 2019

@orlangur hello, test added. Please review.
@ghost ghost assigned sidolov Jun 25, 2019
@sidolov sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 25, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jun 25, 2019

Hi @sidolov, thank you for the review.
ENGCOM-5360 has been created to process this Pull Request
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jun 25, 2019

@NikolasSumrak thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.
@engcom-Alfa engcom-Alfa self-assigned this Jun 27, 2019
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Jun 27, 2019

✔️ QA Passed
@ghost ghost added the Progress: accept label Jun 27, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jun 27, 2019

@NikolasSumrak thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.
@NikolasSumrak NikolasSumrak requested a review from orlangur June 28, 2019 09:37
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Jul 1, 2019
@sidolov
ENGCOM-5360: Fixed apply discount coupons for bundle product magento#…
a65c8e5 
…22987
@magento-engcom-team magento-engcom-team merged commit a2a4e2c into magento:2.3-develop Jul 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 1, 2019

Hi @NikolasSumrak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jul 1, 2019
@NikolasSumrak NikolasSumrak deleted the patch-1 branch July 1, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: OfflineShipping Component: Quote Progress: accept Release Line: 2.3

9 participants

@NikolasSumrak @magento-cicd2 @engcom-Golf @magento-engcom-team @engcom-Alfa @orlangur @sidolov @Nazar65 @engcom-Foxtrot