Skip to content

Conversation

@vdubyna
Copy link

@vdubyna vdubyna commented Mar 25, 2013

Add Default strategy and move the init of the strategy from constructor to the method
getDeployStrategy

Add Default strategy and move the init of the strategy from constructor
@Vinai
Copy link
Member

Vinai commented Mar 25, 2013

Thanks for your contribution! Could you elaborate on the problem you mentioned? How does this patch enable different deploy strategies for different extensions? The extra.magento-deploystrategy setting is from the project's root composer.json.

I'm not rejecting your patch, just want to understand the background fully. Thank you in advance for taking the time to explain.

@vdubyna
Copy link
Author

vdubyna commented Mar 25, 2013

I went deep into the problem and now I see the reason of the current behavior. We are configuring the deploy strategy on a global level and install all the extension using the strategy (symlink, copy).

In my case I've already installed extensions (symlink strategy) and when I tried use a copy for a new one I had a problem with that as default strategy was applied.

Now, I see that my way of thinking was absolutely wrong. There is no need to define the strategy on the extension level.

Please close my pull request.

Maybe we should add to the documentation markers for configs. Example "application configuration", "extension configuration".

Thank you.

@Vinai
Copy link
Member

Vinai commented Mar 25, 2013

Thank you for the update. I agree the documentation could be improved, at least with a notice which settings belong in the root composer.json and which in the package one.

@Vinai Vinai closed this Mar 25, 2013
AydinHassan pushed a commit to AydinHassan/magento-composer-installer that referenced this pull request Jun 10, 2015
…ne_fix fix for array_combine and php 5.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants