Skip to content

Conversation

@barryvdh
Copy link
Contributor

@barryvdh barryvdh commented Mar 4, 2015

I don't think this is used, or am I overlooking something?
It is used here:

protected function movePersistentDirectories($sourceDir, $targetDir)
{
foreach ($this->persistentDirs as $dir) {
$source = $sourceDir . self::DS . $dir;
$target = $targetDir . self::DS . $dir;
if (file_exists($source)) {
$this->emptyDir($target);
$this->fs->copyThenRemove($source, $target);
}
}
}
but that has it's own variable, so this might be confusing.

@Flyingmana
Copy link
Member

The whole class is not existent anymore in the 3.x branch, but for the functionality of the core installer they seem to be important, maybe the correct fix for the 2.x versions would be to implement the usage of it then.

Flyingmana added a commit that referenced this pull request Apr 6, 2015
Remove unused $persistentDirs
@Flyingmana Flyingmana merged commit ed01951 into magento-hackathon:master Apr 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants