Remove ESIntegTestCase#pluginList

It was a useful method in 1.7 when javac's type inference wasn't as good, but now we can just replace it with `Arrays.asList`.

Author: nik9000

core/src/test/java/org/elasticsearch/action/IndicesRequestIT.java

@@ -149,7 +149,7 @@ protected Settings nodeSettings(int ordinal) {
 
  @Override
  protected Collection<Class<? extends Plugin>> nodePlugins() {
- return pluginList(InterceptingTransportService.TestPlugin.class, CustomScriptPlugin.class);
+ return Arrays.asList(InterceptingTransportService.TestPlugin.class, CustomScriptPlugin.class);
  }
 
  public static class CustomScriptPlugin extends MockScriptPlugin {

core/src/test/java/org/elasticsearch/action/admin/cluster/node/tasks/TasksIT.java

@@ -60,6 +60,7 @@
 
 import java.io.IOException;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
@@ -105,7 +106,7 @@ protected boolean addMockTransportService() {
 
  @Override
  protected Collection<Class<? extends Plugin>> nodePlugins() {
- return pluginList(MockTransportService.TestPlugin.class, TestTaskPlugin.class);
+ return Arrays.asList(MockTransportService.TestPlugin.class, TestTaskPlugin.class);
  }
 
  @Override

core/src/test/java/org/elasticsearch/action/admin/indices/shards/IndicesShardStoreRequestIT.java

@@ -41,6 +41,7 @@
 import org.elasticsearch.test.junit.annotations.TestLogging;
 import org.elasticsearch.test.store.MockFSIndexStore;
 
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.HashSet;
@@ -64,7 +65,7 @@ public class IndicesShardStoreRequestIT extends ESIntegTestCase {
 
  @Override
  protected Collection<Class<? extends Plugin>> nodePlugins() {
- return pluginList( MockFSIndexStore.TestPlugin.class);
+ return Arrays.asList( MockFSIndexStore.TestPlugin.class);
  }
 
  public void testEmpty() {

core/src/test/java/org/elasticsearch/bwcompat/IpFieldBwCompatIT.java

@@ -21,6 +21,7 @@
 import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertAcked;
 import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertNoFailures;
 
+import java.util.Arrays;
 import java.util.Collection;
 
 import org.elasticsearch.Version;
@@ -39,7 +40,7 @@ public class IpFieldBwCompatIT extends ESIntegTestCase {
 
  @Override
  protected Collection<Class<? extends Plugin>> nodePlugins() {
- return pluginList(InternalSettingsPlugin.class); // uses index.merge.enabled
+ return Arrays.asList(InternalSettingsPlugin.class); // uses index.merge.enabled
  }
 
  @Override

core/src/test/java/org/elasticsearch/bwcompat/OldIndexBackwardsCompatibilityIT.java

@@ -68,6 +68,7 @@
 import java.io.InputStream;
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
@@ -90,7 +91,7 @@ public class OldIndexBackwardsCompatibilityIT extends ESIntegTestCase {
 
  @Override
  protected Collection<Class<? extends Plugin>> nodePlugins() {
- return pluginList(InternalSettingsPlugin.class);
+ return Arrays.asList(InternalSettingsPlugin.class);
  }
 
  List<String> indexes;

core/src/test/java/org/elasticsearch/cluster/ClusterInfoServiceIT.java

@@ -54,6 +54,7 @@
 import org.hamcrest.Matchers;
 
 import java.io.IOException;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.List;
 import java.util.Set;
@@ -123,7 +124,7 @@ protected Settings nodeSettings(int nodeOrdinal) {
 
  @Override
  protected Collection<Class<? extends Plugin>> nodePlugins() {
- return pluginList(TestPlugin.class,
+ return Arrays.asList(TestPlugin.class,
  MockTransportService.TestPlugin.class);
  }
 

core/src/test/java/org/elasticsearch/cluster/routing/PrimaryAllocationIT.java

@@ -38,6 +38,7 @@
 import org.elasticsearch.test.disruption.NetworkDisruption.TwoPartitions;
 import org.elasticsearch.test.transport.MockTransportService;
 
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
@@ -57,7 +58,7 @@ public class PrimaryAllocationIT extends ESIntegTestCase {
  @Override
  protected Collection<Class<? extends Plugin>> nodePlugins() {
  // disruption tests need MockTransportService
- return pluginList(MockTransportService.TestPlugin.class);
+ return Arrays.asList(MockTransportService.TestPlugin.class);
  }
 
  private void createStaleReplicaScenario() throws Exception {

core/src/test/java/org/elasticsearch/cluster/routing/allocation/decider/MockDiskUsagesIT.java

@@ -32,6 +32,7 @@
 import org.elasticsearch.test.ESIntegTestCase;
 
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.Iterator;
@@ -48,7 +49,7 @@ public class MockDiskUsagesIT extends ESIntegTestCase {
  @Override
  protected Collection<Class<? extends Plugin>> nodePlugins() {
  // Use the mock internal cluster info service, which has fake-able disk usages
- return pluginList(MockInternalClusterInfoService.TestPlugin.class);
+ return Arrays.asList(MockInternalClusterInfoService.TestPlugin.class);
  }
 
  public void testRerouteOccursOnDiskPassingHighWatermark() throws Exception {

core/src/test/java/org/elasticsearch/cluster/service/ClusterServiceIT.java

@@ -63,7 +63,7 @@ public class ClusterServiceIT extends ESIntegTestCase {
 
  @Override
  protected Collection<Class<? extends Plugin>> nodePlugins() {
- return pluginList(TestPlugin.class);
+ return Arrays.asList(TestPlugin.class);
  }
 
  public void testAckedUpdateTask() throws Exception {

core/src/test/java/org/elasticsearch/cluster/settings/SettingsFilteringIT.java

@@ -44,7 +44,7 @@ public class SettingsFilteringIT extends ESIntegTestCase {
 
  @Override
  protected Collection<Class<? extends Plugin>> nodePlugins() {
- return pluginList(SettingsFilteringPlugin.class);
+ return Arrays.asList(SettingsFilteringPlugin.class);
  }
 
  public static class SettingsFilteringPlugin extends Plugin {