Skip to content

Commit 325a733

Browse files
committed
Fix the import issue for user who does not use umbrella header SVGKit.h. Make some cross-platform define inside pch files to avoid effect user's custom define
1 parent d347c31 commit 325a733

File tree

11 files changed

+16
-64
lines changed

11 files changed

+16
-64
lines changed

SVGKitLibrary/SVGKit-iOS/SVGKit-Prefix.pch

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
#import <CocoaLumberjack/CocoaLumberjack.h>
88
#import "SVGKDefine.h"
99

10+
// These macro is only used inside framework project, does not expose to public header and effect user's define
11+
1012
#define SVGKIT_LOG_CONTEXT 556
1113

1214
#define SVGKitLogError(frmt, ...) LOG_MAYBE(NO, LOG_LEVEL_DEF, DDLogFlagError, SVGKIT_LOG_CONTEXT, nil, __PRETTY_FUNCTION__, frmt, ##__VA_ARGS__)
@@ -20,4 +22,10 @@ static const int ddLogLevel = DDLogLevelVerbose;
2022
#else
2123
static const int ddLogLevel = DDLogLevelWarning;
2224
#endif
25+
26+
#if SVGKIT_MAC
27+
#define NSStringFromCGRect(rect) NSStringFromRect(rect)
28+
#define NSStringFromCGSize(size) NSStringFromSize(size)
29+
#define NSStringFromCGPoint(point) NSStringFromPoint(point)
30+
#endif
2331
#endif

Source/DOM classes/SVG-DOM/SVGRect.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,3 @@ CGRect CGRectFromSVGRect( SVGRect rect );
4141
CGSize CGSizeFromSVGRect( SVGRect rect );
4242

4343
NSString * _Nonnull NSStringFromSVGRect( SVGRect rect );
44-
45-
#if SVGKIT_MAC
46-
NSString * _Nonnull NSStringFromCGRect( CGRect rect );
47-
NSString * _Nonnull NSStringFromCGSize( CGSize size );
48-
NSString * _Nonnull NSStringFromCGPoint( CGPoint point );
49-
#endif

Source/DOM classes/SVG-DOM/SVGRect.m

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
#import "SVGRect.h"
2-
#if SVGKIT_UIKIT
3-
#import <UIKit/UIKit.h>
4-
#endif
52

63
BOOL SVGRectIsInitialized( SVGRect rect )
74
{
@@ -41,17 +38,3 @@ CGSize CGSizeFromSVGRect( SVGRect rect )
4138
return NSStringFromCGRect(cgRect);
4239
#endif
4340
}
44-
45-
#if SVGKIT_MAC
46-
NSString * NSStringFromCGRect( CGRect rect ) {
47-
return NSStringFromRect(rect);
48-
}
49-
50-
NSString * _Nonnull NSStringFromCGSize( CGSize size ) {
51-
return NSStringFromSize(size);
52-
}
53-
54-
NSString * NSStringFromCGPoint( CGPoint point ) {
55-
return NSStringFromPoint(point);
56-
}
57-
#endif

Source/DOM classes/Unported or Partial DOM/SVGLinearGradientElement.m

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,6 @@
99
#import "SVGLinearGradientElement.h"
1010
#import "SVGElement_ForParser.h"
1111
#import "SVGGradientLayer.h"
12-
#if SVGKIT_UIKIT
13-
#import <UIKit/UIKit.h>
14-
#else
15-
#import <AppKit/AppKit.h>
16-
#endif
1712

1813
@interface SVGLinearGradientElement ()
1914

Source/DOM classes/Unported or Partial DOM/SVGRadialGradientElement.m

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,6 @@
1010
#import "SVGElement_ForParser.h"
1111
#import "SVGUtils.h"
1212
#import "SVGGradientLayer.h"
13-
#if SVGKIT_UIKIT
14-
#import <UIKit/UIKit.h>
15-
#else
16-
#import <AppKit/AppKit.h>
17-
#endif
1813

1914
// `kCAGradientLayerRadial` this symbol is available since iOS 3.2/tvOS 9.0/macOS 10.6, but it's not externed to public header until Xcode 10 with iOS 12 SDK, so we define it for user who still use old SDK version.
2015
#if (__IPHONE_OS_VERSION_MAX_ALLOWED && __IPHONE_OS_VERSION_MAX_ALLOWED < __IPHONE_12_0) || (__TV_OS_VERSION_MAX_ALLOWED && __TV_OS_VERSION_MAX_ALLOWED < __TVOS_12_0) || (__MAC_OS_X_VERSION_MAX_ALLOWED && __MAC_OS_X_VERSION_MAX_ALLOWED < __MAC_10_14)

Source/DOM classes/Unported or Partial DOM/SVGTextElement.m

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
#import "SVGTextElement.h"
22

33
#import <CoreText/CoreText.h>
4-
#if SVGKIT_MAC
5-
#import <AppKit/AppKit.h>
6-
#else
7-
#import <UIKit/UIKit.h>
8-
#endif
94
#import "SVGElement_ForParser.h" // to resolve Xcode circular dependencies; in long term, parsing SHOULD NOT HAPPEN inside any class whose name starts "SVG" (because those are reserved classes for the SVG Spec)
105
#import "SVGGradientLayer.h"
116
#import "SVGHelperUtilities.h"

Source/QuartzCore additions/CALayerWithClipRender.m

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,6 @@
77
//
88

99
#import "CALayerWithClipRender.h"
10-
#if SVGKIT_MAC
11-
#import <AppKit/AppKit.h>
12-
#else
13-
#import <UIKit/UIKit.h>
14-
#endif
1510

1611
@implementation CALayerWithClipRender
1712

Source/SVGKDefine.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,4 +63,10 @@
6363
#endif
6464
#endif
6565

66+
#if SVGKIT_MAC
67+
#import <AppKit/AppKit.h>
68+
#else
69+
#import <UIKit/UIKit.h>
70+
#endif
71+
6672
#endif /* SVGKDefine_h */

Source/SVGKImage.h

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,7 @@
3535
3636
*/
3737

38-
#if SVGKIT_MAC
39-
#import <AppKit/AppKit.h>
40-
#else
41-
#import <UIKit/UIKit.h>
42-
#endif
43-
38+
#import "SVGKDefine.h"
4439
#import "SVGKParser.h" // needed for asynchronous loading method-signature
4540

4641
@class SVGDocument;

Source/SVGKit.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,8 @@
1919

2020
#define V_1_COMPATIBILITY_COMPILE_CALAYEREXPORTER_CLASS 0
2121

22-
#ifndef SVGKIT_LOG_CONTEXT
23-
#define SVGKIT_LOG_CONTEXT 556
24-
#endif
25-
2622

2723
// MARK: - Framework Header File Content
28-
#if SVGKIT_MAC
29-
#import <AppKit/AppKit.h>
30-
#else
31-
#import <UIKit/UIKit.h>
32-
#endif
3324

3425
@interface SVGKit : NSObject
3526

0 commit comments

Comments
 (0)