refactor: change dto response

Author: luanpersini

src/infrastructure/clients/AuthenticationClient.ts

@@ -1,6 +1,7 @@
 import { Account } from '@modules/authentication/domain/entities/Account'
 import { LoginResultDto } from '@modules/authentication/presentation/dtos/LoginDto'
 import { AccountDto } from '@modules/shared/presentation/dto/AccountDto'
+import { GetAccountResponseDto } from '@modules/users/presentation/dto/getAccountResponseDto'
 import { BadRequestException, Injectable } from '@nestjs/common'
 import * as crypto from 'node:crypto'
 import { IAuthenticationClient } from '../../modules/shared/infrastructure/IAuthenticationClient'
@@ -55,7 +56,7 @@ export class AuthenticationClient implements IAuthenticationClient {
  return false
  }
 
- async getAllAccounts(): Promise<AccountDto[]> {
+ async getAllAccounts(): Promise<GetAccountResponseDto[]> {
  accounts.map((account) => {
  delete account.password
  return account
@@ -67,11 +68,12 @@ export class AuthenticationClient implements IAuthenticationClient {
  return accounts.find((account) => account.email === email)
  }
 
- async getAccountById(id: string): Promise<AccountDto> {
+ async getAccountById(id: string): Promise<GetAccountResponseDto> {
  const accountExists = accounts.find((account) => account.id === id)
  if (!accountExists) {
  throw new BadRequestException(ClientErrorMessages.ACCOUNT_NOT_FOUND)
  }
+ delete accountExists.password
  return accountExists
  }
 

src/modules/shared/infrastructure/IAuthenticationClient.ts

@@ -1,5 +1,6 @@
 import { LoginResultDto } from '@modules/authentication/presentation/dtos/LoginDto'
 import { AccountDto } from '@modules/shared/presentation/dto/AccountDto'
+import { GetAccountResponseDto } from '@modules/users/presentation/dto/getAccountResponseDto'
 
 export interface ClientResult<T> {
  status: number
@@ -10,8 +11,8 @@ export interface IAuthenticationClient {
  createAccount(account: AccountDto): Promise<AccountDto>
  login(email: string, password: string): Promise<LoginResultDto> 
  validateLogin(loginToken: string): Promise<boolean>
- getAllAccounts(): Promise<AccountDto[]> 
+ getAllAccounts(): Promise<GetAccountResponseDto[]> 
  getAccountByEmail(email: string): Promise<AccountDto>
- getAccountById(id: string): Promise<AccountDto>
+ getAccountById(id: string): Promise<GetAccountResponseDto>
  deleteAccountByEmail(email: string): Promise<boolean>
 }

src/modules/users/application/IUsersService.ts

@@ -1,6 +1,6 @@
-import { AccountDto } from '@modules/shared/presentation/dto/AccountDto'
+import { GetAccountResponseDto } from '../presentation/dto/getAccountResponseDto'
 
 export interface IUsersService {
- listAllUsers(): Promise<AccountDto[]>
- getUserById(id: string): Promise<AccountDto>
+ listAllUsers(): Promise<GetAccountResponseDto[]>
+ getUserById(id: string): Promise<GetAccountResponseDto>
 }

src/modules/users/application/UsersService.ts

@@ -1,7 +1,7 @@
 import { InfrastructureInjectionList } from '@infrastructure/InfrastructureInjectionList'
-import { AccountDto } from '@modules/shared/presentation/dto/AccountDto'
 import { Inject, Injectable } from '@nestjs/common'
 import { IAuthenticationClient } from '../../shared/infrastructure/IAuthenticationClient'
+import { GetAccountResponseDto } from '../presentation/dto/getAccountResponseDto'
 import { IUsersService } from './IUsersService'
 
 @Injectable()
@@ -11,11 +11,11 @@ export class UsersService implements IUsersService {
  private readonly authenticationClient: IAuthenticationClient
  ) {}
 
- async listAllUsers(): Promise<AccountDto[]> {
+ async listAllUsers(): Promise<GetAccountResponseDto[]> {
  return await this.authenticationClient.getAllAccounts()
  } 
 
- async getUserById(id: string): Promise<AccountDto> { 
+ async getUserById(id: string): Promise<GetAccountResponseDto> { 
  return await this.authenticationClient.getAccountById(id) 
  } 
 

src/modules/users/presentation/dto/getAccountResponseDto.ts

@@ -0,0 +1,7 @@
+
+export type GetAccountResponseDto = {
+ id: string
+ name: string
+ email: string
+ zipCode: string
+}