Remove the build time jar dependency installation and embedded the jars instead

[purbon]

Clean up jar dependencies code and so we end embedded dependencies the same gem. To do so I introduced a common code to load jars so we aim to simplify the management of jars in the long run. This loading code can be extracted to a common gem when agreed on a way to do this task.

Version 0.1.5 bump

Remove the vendor/ dir from the files added in the gemspec as this directory is no longer in use.

@ph comments? ideas? naming for the common loading module?

[ph]

useless space

[ph]

minor comment but LGTM! I love simplicity.

[wiibaa]

@purbon @ph is it not more or less what logstash::environment is doing for loading elasticsearch jar and could be generalized as proposed in elastic/logstash#1301

[purbon]

Yes @wiibaa, this is the same thing and the basic idea is to generalize this to follow the same pattern everywhere where a jar is required.

[ph]

@wiibaa exactly, we are going to a more simpler flow and one less dependencies system to manage..

[wiibaa]

@purbon @ph thanks for the explanations and sorry for the silly question but shouldn't there be a require "lib/logstash-input-log4j_jars" somewhere ?

[purbon]

@wiibaa https://github.com/logstash-plugins/logstash-input-log4j/blob/master/lib/logstash/inputs/log4j.rb#L9 is there :-)

[ph]

@wiibaa 🍻 :)

[wiibaa]

ok got it, the require was already there, but not the file because it was generated by jar-dependendies at build time...
@ph I should be the one offering the beers ;)
@purbon thanks for the lesson

[ph]

@wiibaa If I ever go to europe I'll accept them.

[colinsurprenant]

oh, I'm in Europe now, I can take care of that 😇

[jsvd]

LGTM (didn't test in a logstash installation)

[elasticsearch-bot]

Merged sucessfully into master!