move testing to docker #37
Conversation
yaauie left a comment
yaauie left a comment There was a problem hiding this comment.
Overall, I think this makes sense, but I have not tested locally; do we plan to port this work to the rest of the plugins via mass_effect?
I added a couple of nitpicks in-line.
.travis.yml Outdated
| - env: SNAPSHOT=true ELASTIC_STACK_VERSION=8.x | ||
| - env: SNAPSHOT=true ELASTIC_STACK_VERSION=7.x | ||
| - env: ELASTIC_STACK_VERSION=7.x | ||
| - env: SNAPSHOT=true ELASTIC_STACK_VERSION=6.x |
There was a problem hiding this comment.
nitpick: for some reason these would make a little more sense to me if we always specified ELASTIC_STACK_VERSION before the optional SNAPSHOT one. I think it visually lets me acknowledge the versions we're testing and then layer on "oh yeah, we also want the snapshot version since we're in active development":
matrix: include: - env: ELASTIC_STACK_VERSION=8.x SNAPSHOT=true - env: ELASTIC_STACK_VERSION=7.x SNAPSHOT=true - env: ELASTIC_STACK_VERSION=7.x - env: ELASTIC_STACK_VERSION=6.x SNAPSHOT=true - env: ELASTIC_STACK_VERSION=6.x - env: ELASTIC_STACK_VERSION=5.x 
I'd like to avoid having our plugin tests build logstash for every test. So either we download the tar.gz or use docker images. I've been leaning towards using docker and been converting some of the plugin tests to use this strategy, which keeps getting refined by comments like yours. I think we'll soon be ready to mass convert plugins to this strategy unless there's some reason not to, wdyt? |
| @yaauie let me know if there are any other concerns here. thanks |
| Tests are failing now on master. Can test setup be updated? |
4 participants
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/