Log a warning when the JSON parsing fails #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lib/logstash/codecs/json_lines.rb Outdated
| LogStash::Event.from_json(json).each { |event| yield event } | ||
| rescue LogStash::Json::ParserError | ||
| rescue LogStash::Json::ParserError => e | ||
| @logger.error("JSON parse error, original data now in message field", :error => e, :data => json) |
Contributor
There was a problem hiding this comment.
Since this condition is automatically recovered by Logstash, I don't think logging it as an error is the right choice. Maybe info? or warn?
Contributor Author
There was a problem hiding this comment.
Fair point. I'll stick to a warning since that matches the default log level. Hiding what should be obvious signs of trouble behind a --verbose invocation seems ill-advised.
magnusbaeck force-pushed the log-parse-errors branch from 0543987 to 54dbff8 Compare 
This mirrors what the json codec already does.
magnusbaeck force-pushed the log-parse-errors branch from 54dbff8 to 90d1ab4 Compare magnusbaeck changed the title 
Contributor Author
| Updated according to your suggestion @jordansissel. Please have another look. |
Contributor
| LGTM |
| Jordan Sissel merged this into the following branches!
|
jsvd pushed a commit to jsvd/logstash-codec-json_lines that referenced this pull request Nov 20, 2019
This mirrors what the json codec already does. Fixes logstash-plugins#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This mirrors what the json codec already does. Fixes #21.