[NFC] [FlowSensitive] LatticeJoinEffect -> LatticeEffect (#160222)

`LatticeJoinEffect` is deprecated.

Author: fmayer

clang/include/clang/Analysis/FlowSensitive/CachedConstAccessorsLattice.h

@@ -90,7 +90,7 @@ template <typename Base> class CachedConstAccessorsLattice : public Base {
  return Base::operator==(Other);
  }
 
- LatticeJoinEffect join(const CachedConstAccessorsLattice &Other);
+ LatticeEffect join(const CachedConstAccessorsLattice &Other);
 
 private:
  // Maps a record storage location and const method to the value to return
@@ -127,15 +127,15 @@ joinConstMethodMap(
  for (auto &[Loc, DeclToT] : Map1) {
  auto It = Map2.find(Loc);
  if (It == Map2.end()) {
- Effect = LatticeJoinEffect::Changed;
+ Effect = LatticeEffect::Changed;
  continue;
  }
  const auto &OtherDeclToT = It->second;
  auto &JoinedDeclToT = Result[Loc];
  for (auto [Func, Var] : DeclToT) {
  T *OtherVar = OtherDeclToT.lookup(Func);
  if (OtherVar == nullptr || OtherVar != Var) {
- Effect = LatticeJoinEffect::Changed;
+ Effect = LatticeEffect::Changed;
  continue;
  }
  JoinedDeclToT.insert({Func, Var});

clang/unittests/Analysis/FlowSensitive/CachedConstAccessorsLatticeTest.cpp

@@ -42,7 +42,7 @@ using ast_matchers::selectFirst;
 
 using dataflow::DataflowAnalysisContext;
 using dataflow::Environment;
-using dataflow::LatticeJoinEffect;
+using dataflow::LatticeEffect;
 using dataflow::RecordStorageLocation;
 using dataflow::Value;
 using dataflow::WatchedLiteralsSolver;
@@ -270,11 +270,11 @@ TEST_F(CachedConstAccessorsLatticeTest, JoinSameNoop) {
 
  LatticeT EmptyLattice;
  LatticeT EmptyLattice2;
- EXPECT_EQ(EmptyLattice.join(EmptyLattice2), LatticeJoinEffect::Unchanged);
+ EXPECT_EQ(EmptyLattice.join(EmptyLattice2), LatticeEffect::Unchanged);
 
  LatticeT Lattice1;
  Lattice1.getOrCreateConstMethodReturnValue(Loc, CE, Env);
- EXPECT_EQ(Lattice1.join(Lattice1), LatticeJoinEffect::Unchanged);
+ EXPECT_EQ(Lattice1.join(Lattice1), LatticeEffect::Unchanged);
 }
 
 TEST_F(CachedConstAccessorsLatticeTest, ProducesNewValueAfterJoinDistinct) {
@@ -289,7 +289,7 @@ TEST_F(CachedConstAccessorsLatticeTest, ProducesNewValueAfterJoinDistinct) {
 
  LatticeT EmptyLattice;
 
- EXPECT_EQ(Lattice1.join(EmptyLattice), LatticeJoinEffect::Changed);
+ EXPECT_EQ(Lattice1.join(EmptyLattice), LatticeEffect::Changed);
  Value *ValAfterJoin =
  Lattice1.getOrCreateConstMethodReturnValue(Loc, CE, Env);
 
@@ -299,7 +299,7 @@ TEST_F(CachedConstAccessorsLatticeTest, ProducesNewValueAfterJoinDistinct) {
  LatticeT Lattice3;
  Value *Val3 = Lattice3.getOrCreateConstMethodReturnValue(Loc, CE, Env);
 
- EXPECT_EQ(Lattice1.join(Lattice3), LatticeJoinEffect::Changed);
+ EXPECT_EQ(Lattice1.join(Lattice3), LatticeEffect::Changed);
  Value *ValAfterJoin2 =
  Lattice1.getOrCreateConstMethodReturnValue(Loc, CE, Env);