[OFFLOAD] Interop fixes for Windows (#162652)

On Windows, for a reason I don't fully understand boolean bits get extra padding (even when asking for packed structures) in the structures that messes the offsets between the compiler and the runtime. Also, "weak" works differently on Windows than Linux (i.e., the "local" routine has preference) which causes it to crash as we don't really have an alternate implementation of __kmpc_omp_wait_deps. Given this, it doesn't make sense to mark it as "weak" for Linux either.

Author: adurang

offload/include/OpenMP/InteropAPI.h

@@ -25,8 +25,8 @@ typedef enum kmp_interop_type_t {
 } kmp_interop_type_t;
 
 struct interop_attrs_t {
- bool inorder : 1;
- int reserved : 31;
+ uint32_t inorder : 1;
+ uint32_t reserved : 31;
 
  /// Check if the supported attributes are compatible with the current
  /// attributes. Only if an attribute is supported can the value be true,
@@ -44,15 +44,15 @@ struct interop_spec_t {
 };
 
 struct interop_flags_t {
- bool implicit : 1; // dispatch (true) or interop (false)
- bool nowait : 1; // has nowait flag
- int reserved : 30;
+ uint32_t implicit : 1; // dispatch (true) or interop (false)
+ uint32_t nowait : 1; // has nowait flag
+ uint32_t reserved : 30;
 };
 
 struct interop_ctx_t {
  uint32_t version; // version of the interface (current is 0)
  interop_flags_t flags;
- int gtid;
+ int32_t gtid;
 };
 
 struct dep_pack_t {

offload/libomptarget/OpenMP/InteropAPI.cpp

@@ -22,8 +22,7 @@ extern "C" {
 
 void __kmpc_omp_wait_deps(ident_t *loc_ref, int32_t gtid, int32_t ndeps,
  kmp_depend_info_t *dep_list, int32_t ndeps_noalias,
- kmp_depend_info_t *noalias_dep_list)
- __attribute__((weak));
+ kmp_depend_info_t *noalias_dep_list);
 
 } // extern "C"