Skip to content

Commit f770ec1

Browse files
authored
common, eth: remove duplicate test cases (ethereum#32624)
Remove redundant duplicate test vectors. The two entries were identical and back-to-back, providing no additional coverage while adding noise. Keeping a single instance maintains test intent and clarity without altering behavior.
1 parent c7eb376 commit f770ec1

File tree

3 files changed

+0
-4
lines changed

3 files changed

+0
-4
lines changed

common/hexutil/json_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -408,7 +408,6 @@ func TestUnmarshalFixedUnprefixedText(t *testing.T) {
408408
{input: "0x2", wantErr: ErrOddLength},
409409
{input: "2", wantErr: ErrOddLength},
410410
{input: "4444", wantErr: errors.New("hex string has length 4, want 8 for x")},
411-
{input: "4444", wantErr: errors.New("hex string has length 4, want 8 for x")},
412411
// check that output is not modified for partially correct input
413412
{input: "444444gg", wantErr: ErrSyntax, want: []byte{0, 0, 0, 0}},
414413
{input: "0x444444gg", wantErr: ErrSyntax, want: []byte{0, 0, 0, 0}},

eth/protocols/snap/gentrie_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,6 @@ func TestPartialGentree(t *testing.T) {
239239
{1, len(entries) - 1}, // no left
240240
{2, len(entries) - 1}, // no left
241241
{2, len(entries) - 2}, // no left and right
242-
{2, len(entries) - 2}, // no left and right
243242
{len(entries) / 2, len(entries) / 2}, // single
244243
{0, 0}, // single first
245244
{len(entries) - 1, len(entries) - 1}, // single last
@@ -348,7 +347,6 @@ func TestGentreeDanglingClearing(t *testing.T) {
348347
{1, len(entries) - 1}, // no left
349348
{2, len(entries) - 1}, // no left
350349
{2, len(entries) - 2}, // no left and right
351-
{2, len(entries) - 2}, // no left and right
352350
{len(entries) / 2, len(entries) / 2}, // single
353351
{0, 0}, // single first
354352
{len(entries) - 1, len(entries) - 1}, // single last

eth/protocols/snap/sync_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,6 @@ func testSyncBloatedProof(t *testing.T, scheme string) {
597597
proof := trienode.NewProofSet()
598598
if err := t.accountTrie.Prove(origin[:], proof); err != nil {
599599
t.logger.Error("Could not prove origin", "origin", origin, "error", err)
600-
t.logger.Error("Could not prove origin", "origin", origin, "error", err)
601600
}
602601
// The bloat: add proof of every single element
603602
for _, entry := range t.accountValues {

0 commit comments

Comments
 (0)