Skip to content

Commit 1728251

Browse files
committed
add note to CHANGELOG
and neaten the loops slightly see #284
1 parent 1e66eef commit 1728251

File tree

2 files changed

+5
-14
lines changed

2 files changed

+5
-14
lines changed

CHANGELOG.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
* don't generate docs for deprecated arguments [jcupitt]
1313
* buffer save tries with the target API first [jcupitt]
1414
* add hyperbolic functions `sinh`, `cosh`, `tanh`, `asinh`, `acosh`, `atanh`
15+
* add `values_for_flag` [kleisauke]
1516

1617
## Version 2.1.15 (27 Dec 2020)
1718

pyvips/base.py

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -120,28 +120,18 @@ def values_for_enum(gtype):
120120
g_type_class = gobject_lib.g_type_class_ref(gtype)
121121
g_enum_class = ffi.cast('GEnumClass *', g_type_class)
122122

123-
values = []
124-
125123
# -1 since we always have a "last" member.
126-
for i in range(0, g_enum_class.n_values - 1):
127-
value = _to_string(g_enum_class.values[i].value_nick)
128-
values.append(value)
129-
130-
return values
124+
return [_to_string(g_enum_class.values[i].value_nick)
125+
for i range(g_enum_class.n_values - 1))]
131126

132127
def values_for_flag(gtype):
133128
"""Get all values for a flag (gtype)."""
134129

135130
g_type_class = gobject_lib.g_type_class_ref(gtype)
136131
g_flags_class = ffi.cast('GFlagsClass *', g_type_class)
137132

138-
values = []
139-
140-
for i in range(0, g_flags_class.n_values):
141-
value = _to_string(g_flags_class.values[i].value_nick)
142-
values.append(value)
143-
144-
return values
133+
return [_to_string(g_flags_class.values[i].value_nick)
134+
for i in range(0, g_flags_class.n_values)]
145135

146136
__all__ = [
147137
'leak_set',

0 commit comments

Comments
 (0)