Bug fix in marching_tets #1337
Merged
Bug fix in marching_tets #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jdumas reviewed Nov 2, 2019
include/igl/marching_tets.cpp Outdated
| assert(ti>=0); | ||
| assert(ti<TT.rows()); | ||
| // this will overwrite, but should be with the same value | ||
| J(f) = ti; |
Collaborator
There was a problem hiding this comment.
We could also move the const int ti = faces[f].second; outside the loop on v.
EDIT: Done.
J was not always being filled in and then it was erroneously resized to the wrong length. This most immediately _**broke**_ the WindingNumber tutorial.
jdumas force-pushed the alecjacobson-patch-1 branch from bfc172f to 3b0cd79 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
J was not always being filled in and then it was erroneously resized to the wrong length. This most immediately broke the WindingNumber tutorial.