Deprecate RBParametrized::get_parameter_names()

Author: jwpeterson

include/reduced_basis/rb_parametrized.h

@@ -90,6 +90,11 @@ class RBParametrized : public ReferenceCountedObject<RBParametrized>
 
  /**
  * Get a set that stores the parameter names.
+ *
+ * \deprecated to avoid making it too easy to create copies that in
+ * most circumstances aren't needed. If this functionality really
+ * is required, call get_parameters_min().get_parameters_map() and
+ * loop over the keys directly.
  */
  std::set<std::string> get_parameter_names() const;
 

src/reduced_basis/rb_parametrized.C

@@ -129,10 +129,9 @@ unsigned int RBParametrized::get_n_discrete_params() const
 
 std::set<std::string> RBParametrized::get_parameter_names() const
 {
+ libmesh_deprecated();
  libmesh_error_msg_if(!parameters_initialized, "Error: parameters not initialized in RBParametrized::get_parameter_names");
 
- // TODO: We may also want to deprecate this funtion since there is
- // already a public accessor for the parameters_min member.
  std::set<std::string> parameter_names;
  const auto & params_map = parameters_min.get_parameters_map();
  for (const auto & pr : params_map)