Add a time_since_oldest gauge, and rename the gauges a bit

Author: jcjones

partitionmanager/cli.py

@@ -211,8 +211,13 @@ def stats_cmd(args):
  "total", help_text="Total number of partitions", type="counter"
  )
  metrics.describe(
- "time_since_last_partitioned_seconds",
- help_text="How many seconds since the last partition was created",
+ "time_since_newest_partition_seconds",
+ help_text="The age in seconds of the last partition for the table",
+ type="gauge",
+ )
+ metrics.describe(
+ "time_since_oldest_partition_seconds",
+ help_text="The age in seconds of the first partition for the table",
  type="gauge",
  )
  metrics.describe(
@@ -229,11 +234,17 @@ def stats_cmd(args):
  for table, results in all_results.items():
  if "partitions" in results:
  metrics.add("total", table, results["partitions"])
- if "time_since_last_partition" in results:
+ if "time_since_newest_partition" in results:
+ metrics.add(
+ "time_since_newest_partition_seconds",
+ table,
+ results["time_since_newest_partition"].total_seconds(),
+ )
+ if "time_since_oldest_partition" in results:
  metrics.add(
- "time_since_last_partitioned_seconds",
+ "time_since_oldest_partition_seconds",
  table,
- results["time_since_last_partition"].total_seconds(),
+ results["time_since_oldest_partition"].total_seconds(),
  )
  if "mean_partition_delta" in results:
  metrics.add(

partitionmanager/cli_test.py

@@ -189,7 +189,12 @@ def test_stats(self):
  )
  r = stats_cmd(args)
  self.assertEqual(r["partitioned_yesterday"]["partitions"], 3)
- self.assertLess(r["partitioned_yesterday"]["time_since_last_partition"].days, 2)
+ self.assertLess(
+ r["partitioned_yesterday"]["time_since_newest_partition"].days, 2
+ )
+ self.assertLess(
+ r["partitioned_yesterday"]["time_since_oldest_partition"].days, 32
+ )
  self.assertGreater(r["partitioned_yesterday"]["mean_partition_delta"].days, 2)
  self.assertGreater(r["partitioned_yesterday"]["max_partition_delta"].days, 2)
 

partitionmanager/stats.py

@@ -74,7 +74,9 @@ def get_statistics(partitions, current_timestamp, table):
  raise UnexpectedPartitionException(tail_part)
 
  if tail_part.timestamp():
- results["time_since_last_partition"] = current_timestamp - tail_part.timestamp()
+ results["time_since_newest_partition"] = (
+ current_timestamp - tail_part.timestamp()
+ )
 
  for p in partitions:
  if p.timestamp():
@@ -84,6 +86,11 @@ def get_statistics(partitions, current_timestamp, table):
  if not head_part or head_part == tail_part:
  return results
 
+ if head_part.timestamp():
+ results["time_since_oldest_partition"] = (
+ current_timestamp - head_part.timestamp()
+ )
+
  if head_part.timestamp() and tail_part.timestamp():
  results["mean_partition_delta"] = (
  tail_part.timestamp() - head_part.timestamp()

partitionmanager/stats_test.py

@@ -29,7 +29,7 @@ def test_statistics_single_partition(self):
  [MaxValuePartition("p_19480113", 1)], ts, Table("single_part")
  )
  self.assertEqual(
- s, {"partitions": 1, "time_since_last_partition": timedelta(days=365)}
+ s, {"partitions": 1, "time_since_newest_partition": timedelta(days=365)}
  )
 
  def test_statistics_two_partitions(self):
@@ -42,7 +42,8 @@ def test_statistics_two_partitions(self):
  s,
  {
  "partitions": 2,
- "time_since_last_partition": timedelta(days=11),
+ "time_since_newest_partition": timedelta(days=11),
+ "time_since_oldest_partition": timedelta(days=377),
  "mean_partition_delta": timedelta(days=366),
  "max_partition_delta": timedelta(days=366),
  },
@@ -63,7 +64,8 @@ def test_statistics_weekly_partitions_year(self):
  s,
  {
  "partitions": 53,
- "time_since_last_partition": timedelta(days=14),
+ "time_since_newest_partition": timedelta(days=14),
+ "time_since_oldest_partition": timedelta(days=378),
  "mean_partition_delta": timedelta(days=7),
  "max_partition_delta": timedelta(days=7),
  },