fix: remove all remaining lodash usage (#4207)

Author: JamesHenry

libs/core/src/lib/cycles/merge-overlapping-cycles.spec.ts

@@ -18,4 +18,42 @@ describe("mergeOverlappingCycles", () => {
  ["package-z", "package-zz", "package-zzz", "package-zzzz"],
  ]);
  });
+
+ it("should handle empty cycles", () => {
+ expect(mergeOverlappingCycles([])).toEqual([]);
+ });
+
+ it("should handle single cycle", () => {
+ const cycles = [["package-a", "package-b", "package-c"]];
+ expect(mergeOverlappingCycles(cycles)).toEqual([["package-a", "package-b", "package-c"]]);
+ });
+
+ it("should handle cycles with no overlaps", () => {
+ const cycles = [
+ ["package-a", "package-b"],
+ ["package-c", "package-d"],
+ ["package-e", "package-f"],
+ ];
+ expect(mergeOverlappingCycles(cycles)).toEqual([
+ ["package-a", "package-b"],
+ ["package-c", "package-d"],
+ ["package-e", "package-f"],
+ ]);
+ });
+
+ it("should handle cycles with complete overlap", () => {
+ const cycles = [
+ ["package-a", "package-b", "package-c"],
+ ["package-a", "package-b", "package-c"],
+ ];
+ expect(mergeOverlappingCycles(cycles)).toEqual([["package-a", "package-b", "package-c"]]);
+ });
+
+ it("should handle cycles with partial overlap", () => {
+ const cycles = [
+ ["package-a", "package-b"],
+ ["package-b", "package-c"],
+ ];
+ expect(mergeOverlappingCycles(cycles)).toEqual([["package-a", "package-b", "package-c"]]);
+ });
 });

libs/core/src/lib/cycles/merge-overlapping-cycles.ts

@@ -1,4 +1,16 @@
-import { difference, intersection } from "lodash";
+/**
+ * Returns an array of elements that are present in both input arrays
+ */
+function intersection<T>(arr1: T[], arr2: T[]): T[] {
+ return arr1.filter((item) => arr2.includes(item));
+}
+
+/**
+ * Returns an array of elements from the first array that are not present in the second array
+ */
+function difference<T>(arr1: T[], arr2: T[]): T[] {
+ return arr1.filter((item) => !arr2.includes(item));
+}
 
 /**
  * Merges all cycles that share nodes into a single cycle, then returns all merged cycles. This allows all cycle nodes to be traversed without repeating any nodes.

package-lock.json

@@ -57,7 +57,6 @@
  "@types/jest": "29.5.14",
  "@types/js-yaml": "^4.0.9",
  "@types/libnpmpublish": "^9.0.0",
- "@types/lodash": "^4.17.5",
  "@types/node": "18.19.10",
  "@types/node-fetch": "^2.6.11",
  "@types/normalize-path": "^3.0.2",
@@ -83,7 +82,6 @@
  "js-yaml": "^4.1.0",
  "jsonc-eslint-parser": "^2.4.0",
  "lerna": "file:packages/lerna",
- "lodash": "^4.17.21",
  "normalize-newline": "^3.0.0",
  "normalize-path": "^3.0.0",
  "nx": "20.7.2",
@@ -98,6 +96,5 @@
  "typescript": "5.8.3",
  "typescript-eslint": "^8.38.0",
  "verdaccio": "6.1.5"
- },
- "dependencies": {}
+ }
 }

package.json

@@ -63,7 +63,6 @@
  "js-yaml": "4.1.0",
  "libnpmpublish": "9.0.9",
  "load-json-file": "6.2.0",
- "lodash": "^4.17.21",
  "make-dir": "4.0.0",
  "minimatch": "3.0.5",
  "multimatch": "5.0.0",

packages/legacy-structure/commands/create/package.json

@@ -77,7 +77,6 @@
  "libnpmaccess": "8.0.6",
  "libnpmpublish": "9.0.9",
  "load-json-file": "6.2.0",
- "lodash": "^4.17.21",
  "make-dir": "4.0.0",
  "minimatch": "3.0.5",
  "multimatch": "5.0.0",