Updated "notes" editor to hold the markup

Instead of building it up in C# code and passing it as config.

Author: leekelleher

src/App_Plugins/CustomValueConverter/notes.html

@@ -3,4 +3,9 @@
  - License, v. 2.0. If a copy of the MPL was not distributed with this
  - file, You can obtain one at https://mozilla.org/MPL/2.0/. -->
 
-<div class="umb-readonlyvalue" ng-bind-html="model.config.notes | safe_html"></div>
+<div class="umb-readonlyvalue">
+ <details class="well well-small">
+ <summary><strong ng-bind="model.config.heading"></strong></summary>
+ <div ng-bind-html="model.config.message | safe_html"></div>
+ </details>
+</div>

src/DataEditor/CustomValueConverterConfigurationEditor.cs

@@ -53,13 +53,11 @@ public CustomValueConverterConfigurationEditor(
  View = ioHelper.ResolveRelativeOrVirtualUrl(NotesViewPath),
  Config = new Dictionary<string, object>
  {
- { "notes", @"<details class=""well well-small"">
-<summary><strong>A note about changing the default value converter.</strong></summary>
-<p>Some of Umbraco's built-in value converters are designed to work explicitly with their associated property editor and data type configuration.</p>
+ { "heading", "A note about changing the default value converter." },
+ { "message", @"<p>Some of Umbraco's built-in value converters are designed to work explicitly with their associated property editor and data type configuration.</p>
 <p>This means they may not be hot-swappable. For example, the <code>MediaPicker</code> and <code>MultiNodeTreePicker</code> value converters will try to detect if the data type is configured for single or multiple use. So if you wanted to change the value converter for a textstring editor, then the target value converter would not be aware of the intended configuration, and potentially cause an error.</p>
 <p>For primitive values, e.g. integer, decimal, string, boolean. These should work as expected.</p>
-<p>If you are using you own custom value converter code, then you don't need to be concerned with this note, you will have full control over the value conversion.</p>
-</details>" },
+<p>If you are using you own custom value converter code, then you don't need to be concerned with this note, you will have full control over the value conversion.</p>" },
  },
  HideLabel = true,
  });