Skip to content

Commit 96f4d5e

Browse files
committed
fixed use of wrong constant, closes mitreid-connect#940
1 parent a5701f4 commit 96f4d5e

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

openid-connect-server/src/main/java/org/mitre/openid/connect/token/TofuUserApprovalHandler.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@
1616
*******************************************************************************/
1717
package org.mitre.openid.connect.token;
1818

19+
import static org.mitre.openid.connect.request.ConnectRequestParameters.APPROVED_SITE;
20+
import static org.mitre.openid.connect.request.ConnectRequestParameters.PROMPT;
21+
import static org.mitre.openid.connect.request.ConnectRequestParameters.PROMPT_CONSENT;
22+
import static org.mitre.openid.connect.request.ConnectRequestParameters.PROMPT_SEPARATOR;
23+
1924
import java.util.Calendar;
2025
import java.util.Collection;
2126
import java.util.Date;
@@ -47,10 +52,6 @@
4752
import com.google.common.base.Strings;
4853
import com.google.common.collect.Sets;
4954

50-
import static org.mitre.openid.connect.request.ConnectRequestParameters.APPROVED_SITE;
51-
import static org.mitre.openid.connect.request.ConnectRequestParameters.PROMPT;
52-
import static org.mitre.openid.connect.request.ConnectRequestParameters.PROMPT_SEPARATOR;
53-
5455
/**
5556
* Custom User Approval Handler implementation which uses a concept of a whitelist,
5657
* blacklist, and greylist.
@@ -132,7 +133,7 @@ public AuthorizationRequest checkForPreApproval(AuthorizationRequest authorizati
132133
// find out if we're supposed to force a prompt on the user or not
133134
String prompt = (String) authorizationRequest.getExtensions().get(PROMPT);
134135
List<String> prompts = Splitter.on(PROMPT_SEPARATOR).splitToList(Strings.nullToEmpty(prompt));
135-
if (!prompts.contains(PROMPT_SEPARATOR)) {
136+
if (!prompts.contains(PROMPT_CONSENT)) {
136137
// if the prompt parameter is set to "consent" then we can't use approved sites or whitelisted sites
137138
// otherwise, we need to check them below
138139

0 commit comments

Comments
 (0)