made props protected, made basic build method, made variations method with tests

Author: joemalin95

src/LaunchDarkly/Integrations/TestData.php

@@ -4,7 +4,7 @@
 
 class TestData {
 
- public function flag($key)
+ public function flag(string $key): FlagBuilder
  {
 
  return new FlagBuilder($key);
@@ -15,6 +15,21 @@ public function flag($key)
 
 class FlagBuilder {
 
+ /** @var string */
+ protected $_key;
+ /** @var boolean */
+ protected $_on;
+ /** @var array */
+ protected $_variations;
+ /** @var int|null */
+ protected $_off_variation;
+ /** @var int|null */
+ protected $_fallthrough_variation;
+ /** @var array */
+ protected $_targets;
+ /** @var array */
+ protected $_rules;
+
  public function __construct(string $key)
  {
 
@@ -63,11 +78,53 @@ public function copy()
  * @param bool $on true if targeting should be on
  * @return FlagBuilder the flag builder object
  */
- public function on($on) {
+ public function on($on)
+ {
 
  $this->_on = $on;
  return $this;
 
  }
 
+ /** 
+ * Changes the allowable variation values for the flag. 
+ * 
+ * The value may be of any valid JSON type. For instance, a boolean flag
+ * normally has True, False; a string-valued flag might have
+ * 'red', 'green'; etc.
+ *
+ * Example: A single variation
+ *
+ * $td->flag('new-flag')->variations(True)
+ *
+ * Example: Multiple variations
+ *
+ * $td->flag('new-flag')->variations('red', 'green', 'blue')
+ *
+ * @param array $variations the the desired variations
+ * @return FlagBuilder the flag builder object
+ */ 
+ public function variations(...$variations): FlagBuilder
+ {
+
+ if (count($variations) == 1) {
+ if (is_array($variations[0])) {
+ $variations = $variations[0];
+ }
+ }
+ $this->_variations = $variations;
+ return $this;
+ }
+
+ public function build(int $version): array
+ {
+ $base_flag_object = [
+ 'key' => $this->_key,
+ 'version' => $version,
+ 'on' => $this->_on,
+ 'variations' => $this->_variations
+ ];
+ return $base_flag_object;
+ }
+
 }

tests/Integrations/TestDataTest.php

@@ -12,8 +12,8 @@ public function testMakesFlag()
  $td = new TestData();
  $flag = $td->flag('test-flag');
 
- $this->assertEquals('test-flag', $flag->_key);
- $this->assertEquals(true, $flag->_on);
+ $this->assertEquals('test-flag', $flag->build(0)['key']);
+ $this->assertEquals(true, $flag->build(0)['on']);
 
  }
 
@@ -22,17 +22,32 @@ public function testMakesCopy()
  $td = new TestData();
  $flag = $td->flag('test-flag');
 
- $flag->_variations = [1,2,3];
+ $flag->variations([1,2,3]);
 
- $this->assertEquals([1,2,3], $flag->_variations);
+ $this->assertEquals([1,2,3], $flag->build(0)['variations']);
 
  $flagCopy = $flag->copy();
 
- $flagCopy->_variations = [4,5,6];
+ $flagCopy->variations([4,5,6]);
 
- $this->assertEquals([1,2,3], $flag->_variations);
- $this->assertEquals([4,5,6], $flagCopy->_variations);
+ $this->assertEquals([1,2,3], $flag->build(0)['variations']);
+ $this->assertEquals([4,5,6], $flagCopy->build(0)['variations']);
 
  }
 
+ public function testSetsVariations()
+ {
+ $td = new TestData();
+ $flag = $td->flag('new-flag')->variations('red', 'green', 'blue');
+ $this->assertEquals(['red', 'green', 'blue'], $flag->build(0)['variations']);
+
+ $flag2 = $td->flag('new-flag-2')->variations(['red', 'green', 'blue']);
+ $this->assertEquals(['red', 'green', 'blue'], $flag2->build(0)['variations']);
+
+ $flag3 = $td->flag('new-flag-3')->variations(['red', 'green', 'blue'], ['cat', 'dog', 'fish']);
+ $this->assertEquals([['red', 'green', 'blue'], ['cat', 'dog', 'fish']], $flag3->build(0)['variations']);
+
+ $flag4 = $td->flag('new-flag-4')->variations([['red', 'green', 'blue']]);
+ $this->assertEquals(['red', 'green', 'blue'], $flag4->build(0)['variations'][0]);
+ }
 }