Static code analysis with Php Inspections (EA Extended)

Author: kalessil

src/Symfony/Bridge/Twig/Extension/CodeExtension.php

@@ -138,7 +138,7 @@ public function fileExcerpt($file, $line)
  $code = @highlight_file($file, true);
  // remove main code/span tags
  $code = preg_replace('#^<code.*?>\s*<span.*?>(.*)</span>\s*</code>#s', '\\1', $code);
- $content = preg_split('#<br />#', $code);
+ $content = explode('<br />', $code);
 
  $lines = array();
  for ($i = max($line - 3, 1), $max = min($line + 3, count($content)); $i <= $max; ++$i) {

src/Symfony/Bridge/Twig/Tests/Extension/HttpKernelExtensionTest.php

@@ -62,9 +62,7 @@ protected function getFragmentHandler($return)
 
  $context->expects($this->any())->method('getCurrentRequest')->will($this->returnValue(Request::create('/')));
 
- $renderer = new FragmentHandler(array($strategy), false, $context);
-
- return $renderer;
+ return new FragmentHandler(array($strategy), false, $context);
  }
 
  protected function renderTemplate(FragmentHandler $renderer, $template = '{{ render("foo") }}')

src/Symfony/Bundle/FrameworkBundle/Templating/Helper/CodeHelper.php

@@ -132,7 +132,7 @@ public function fileExcerpt($file, $line)
  $code = @highlight_file($file, true);
  // remove main code/span tags
  $code = preg_replace('#^<code.*?>\s*<span.*?>(.*)</span>\s*</code>#s', '\\1', $code);
- $content = preg_split('#<br />#', $code);
+ $content = explode('<br />', $code);
 
  $lines = array();
  for ($i = max($line - 3, 1), $max = min($line + 3, count($content)); $i <= $max; ++$i) {

src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Resources/views/translation.html.php

@@ -46,4 +46,4 @@
 
 <?php echo $view['translator']->trans('typecast', ['a' => (int) '123'], 'not_messages'); ?>
 <?php echo $view['translator']->transChoice('msg1', 10 + 1, [], 'not_messages'); ?>
-<?php echo $view['translator']->transChoice('msg2', intval(4.5), [], 'not_messages'); ?>
+<?php echo $view['translator']->transChoice('msg2', ceil(4.5), [], 'not_messages'); ?>

src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/SimpleFormFactory.php

@@ -77,17 +77,4 @@ protected function createListener($container, $id, $config, $userProvider)
 
  return $listenerId;
  }
-
- protected function createEntryPoint($container, $id, $config, $defaultEntryPoint)
- {
- $entryPointId = 'security.authentication.form_entry_point.'.$id;
- $container
- ->setDefinition($entryPointId, new DefinitionDecorator('security.authentication.form_entry_point'))
- ->addArgument(new Reference('security.http_utils'))
- ->addArgument($config['login_path'])
- ->addArgument($config['use_forward'])
- ;
-
- return $entryPointId;
- }
 }

src/Symfony/Component/DependencyInjection/Tests/CrossCheckTest.php

@@ -36,7 +36,7 @@ public function testCrossCheck($fixture, $type)
 
  $tmp = tempnam(sys_get_temp_dir(), 'sf');
 
- file_put_contents($tmp, file_get_contents(self::$fixturesPath.'/'.$type.'/'.$fixture));
+ copy(self::$fixturesPath.'/'.$type.'/'.$fixture, $tmp);
 
  $container1 = new ContainerBuilder();
  $loader1 = new $loaderClass($container1, new FileLocator());

src/Symfony/Component/HttpFoundation/BinaryFileResponse.php

@@ -164,7 +164,7 @@ public function setContentDisposition($disposition, $filename = '', $filenameFal
  if ('' === $filenameFallback && (!preg_match('/^[\x20-\x7e]*$/', $filename) || false !== strpos($filename, '%'))) {
  $encoding = mb_detect_encoding($filename, null, true);
 
- for ($i = 0; $i < mb_strlen($filename, $encoding); ++$i) {
+ for ($i = 0, $filenameLength = mb_strlen($filename, $encoding); $i < $filenameLength; ++$i) {
  $char = mb_substr($filename, $i, 1, $encoding);
 
  if ('%' === $char || ord($char) < 32 || ord($char) > 126) {

src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MongoDbSessionHandlerTest.php

@@ -108,7 +108,7 @@ public function testRead()
 
  if (phpversion('mongodb')) {
  $that->assertInstanceOf('MongoDB\BSON\UTCDateTime', $criteria[$that->options['expiry_field']]['$gte']);
- $that->assertGreaterThanOrEqual(round(intval((string) $criteria[$that->options['expiry_field']]['$gte']) / 1000), $testTimeout);
+ $that->assertGreaterThanOrEqual(round(((int) $criteria[$that->options['expiry_field']]['$gte']) / 1000), $testTimeout);
  } else {
  $that->assertInstanceOf('MongoDate', $criteria[$that->options['expiry_field']]['$gte']);
  $that->assertGreaterThanOrEqual($criteria[$that->options['expiry_field']]['$gte']->sec, $testTimeout);
@@ -167,7 +167,7 @@ public function testWrite()
  $that->assertEquals('bar', $data[$that->options['data_field']]->getData());
  $that->assertInstanceOf('MongoDB\BSON\UTCDateTime', $data[$that->options['time_field']]);
  $that->assertInstanceOf('MongoDB\BSON\UTCDateTime', $data[$that->options['expiry_field']]);
- $that->assertGreaterThanOrEqual($expectedExpiry, round(intval((string) $data[$that->options['expiry_field']]) / 1000));
+ $that->assertGreaterThanOrEqual($expectedExpiry, round(((int) $data[$that->options['expiry_field']]) / 1000));
  } else {
  $that->assertEquals('bar', $data[$that->options['data_field']]->bin);
  $that->assertInstanceOf('MongoDate', $data[$that->options['time_field']]);
@@ -293,7 +293,7 @@ public function testGc()
  ->will($this->returnCallback(function ($criteria) use ($that) {
  if (phpversion('mongodb')) {
  $that->assertInstanceOf('MongoDB\BSON\UTCDateTime', $criteria[$that->options['expiry_field']]['$lt']);
- $that->assertGreaterThanOrEqual(time() - 1, round(intval((string) $criteria[$that->options['expiry_field']]['$lt']) / 1000));
+ $that->assertGreaterThanOrEqual(time() - 1, round(((int) $criteria[$that->options['expiry_field']]['$lt']) / 1000));
  } else {
  $that->assertInstanceOf('MongoDate', $criteria[$that->options['expiry_field']]['$lt']);
  $that->assertGreaterThanOrEqual(time() - 1, $criteria[$that->options['expiry_field']]['$lt']->sec);

src/Symfony/Component/HttpKernel/Client.php

@@ -25,6 +25,9 @@
  * Client simulates a browser and makes requests to a Kernel object.
  *
  * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @method Request|null getRequest() A Request instance
+ * @method Response|null getResponse() A Response instance
  */
 class Client extends BaseClient
 {
@@ -47,26 +50,6 @@ public function __construct(HttpKernelInterface $kernel, array $server = array()
  parent::__construct($server, $history, $cookieJar);
  }
 
- /**
- * {@inheritdoc}
- *
- * @return Request|null A Request instance
- */
- public function getRequest()
- {
- return parent::getRequest();
- }
-
- /**
- * {@inheritdoc}
- *
- * @return Response|null A Response instance
- */
- public function getResponse()
- {
- return parent::getResponse();
- }
-
  /**
  * Makes a request.
  *

src/Symfony/Component/HttpKernel/DataCollector/Util/ValueExporter.php

@@ -33,7 +33,7 @@ public function exportValue($value, $depth = 1, $deep = false)
 
  if (is_object($value)) {
  if ($value instanceof \DateTime || $value instanceof \DateTimeInterface) {
- return sprintf('Object(%s) - %s', get_class($value), $value->format(\DateTime::ISO8601));
+ return sprintf('Object(%s) - %s', get_class($value), $value->format(\DateTime::ATOM));
  }
 
  return sprintf('Object(%s)', get_class($value));