[10.x] fix: prevent casting empty string to array from triggering json error #52415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| Thank you sir! |
| when will this be applied to Laravel 11 ? |
Member
| @Arkhas next Tuesday most likely |
Contributor
| @driesvints Hey Dries! Will this make the Laravel 11 cut today? I just spent a couple of hours pulling my hair out debugging this issue this morning and was super relieved to find this PR. |
Member
| Tomorrow. We didn't do releases last week. |
Contributor
| All good. Thanks @driesvints 🙌 |
This was referenced Oct 31, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello!
Please see #52293 (comment) for context.
This PR prevents json errors being triggered when trying to cast Model attributes with empty strings (invalid json) to an array.
Thanks!