Skip to content

Laravel Horizon pop params wrong #53063

@bbashy

Description

@bbashy

Laravel Version

11.27.0

PHP Version

8.3.12

Database Driver & Version

No response

Description

After upgrading from 11.26.0 to 11.27.0 this error happens for php artisan horizon

 INFO Shutting down. Symfony\Component\ErrorHandler\Error\FatalError Declaration of Laravel\Horizon\RedisQueue::pop($queue = null) must be compatible with Illuminate\Queue\RedisQueue::pop($queue = null, $index = 0) at vendor/laravel/horizon/src/RedisQueue.php:131 127▕ * 128▕ * @param string $queue 129▕ * @return \Illuminate\Contracts\Queue\Job|null 130▕ */ ➜ 131▕ public function pop($queue = null) 132▕ { 133▕ return tap(parent::pop($queue), function ($result) use ($queue) { 134▕ if ($result) { 135▕ $this->event($this->getQueue($queue), new JobReserved($result->getReservedJob())); Whoops\Exception\ErrorException Declaration of Laravel\Horizon\RedisQueue::pop($queue = null) must be compatible with Illuminate\Queue\RedisQueue::pop($queue = null, $index = 0) at vendor/laravel/horizon/src/RedisQueue.php:131 127▕ * 128▕ * @param string $queue 129▕ * @return \Illuminate\Contracts\Queue\Job|null 130▕ */ ➜ 131▕ public function pop($queue = null) 132▕ { 133▕ return tap(parent::pop($queue), function ($result) use ($queue) { 134▕ if ($result) { 135▕ $this->event($this->getQueue($queue), new JobReserved($result->getReservedJob())); +1 vendor frames 2 [internal]:0 Whoops\Run::handleShutdown() 

Downgrading fixes it.

Steps To Reproduce

Run php artisan horizon even if not using redis for queues.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions