fix: AsCommand properties not being set on commands (#56236)

The Symfony Command uses the AsCommand attribute to set properties on the command class. However, the properties are only set if they are identical to an empty string. The Laravel Command class overrides the properties and removes the default value which causes the properties to be null and therefore not set.

Author: calebdw

src/Illuminate/Console/Command.php

@@ -45,16 +45,16 @@ class Command extends SymfonyCommand
  /**
  * The console command description.
  *
- * @var string|null
+ * @var string
  */
- protected $description;
+ protected $description = '';
 
  /**
  * The console command help text.
  *
  * @var string
  */
- protected $help;
+ protected $help = '';
 
  /**
  * Indicates whether the command should be shown in the Artisan command list.
@@ -103,13 +103,13 @@ public function __construct()
  // Once we have constructed the command, we'll set the description and other
  // related properties of the command. If a signature wasn't used to build
  // the command we'll set the arguments and the options on this command.
- if (! isset($this->description)) {
- $this->setDescription((string) static::getDefaultDescription());
- } else {
- $this->setDescription((string) $this->description);
+ if (! empty($this->description)) {
+ $this->setDescription($this->description);
  }
 
- $this->setHelp((string) $this->help);
+ if (! empty($this->help)) {
+ $this->setHelp($this->help);
+ }
 
  $this->setHidden($this->isHidden());