Updated access modifiers from private to protected across multiple files (#249)

Co-authored-by: Ashley Hindle <ashleyhindle@users.noreply.github.com>

Author: andrey-helldar

src/BoostServiceProvider.php

@@ -76,7 +76,7 @@ public function boot(Router $router): void
  }
  }
 
- private function registerPublishing(): void
+ protected function registerPublishing(): void
  {
  if ($this->app->runningInConsole()) {
  $this->publishes([
@@ -85,7 +85,7 @@ private function registerPublishing(): void
  }
  }
 
- private function registerCommands(): void
+ protected function registerCommands(): void
  {
  if ($this->app->runningInConsole()) {
  $this->commands([
@@ -96,7 +96,7 @@ private function registerCommands(): void
  }
  }
 
- private function registerRoutes(): void
+ protected function registerRoutes(): void
  {
  Route::post('/_boost/browser-logs', function (Request $request) {
  $logs = $request->input('logs', []);
@@ -156,7 +156,7 @@ private static function buildLogMessageFromData(array $data): string
  return implode(' ', $messages);
  }
 
- private function registerBrowserLogger(): void
+ protected function registerBrowserLogger(): void
  {
  config([
  'logging.channels.browser' => [
@@ -168,19 +168,19 @@ private function registerBrowserLogger(): void
  ]);
  }
 
- private function registerBladeDirectives(BladeCompiler $bladeCompiler): void
+ protected function registerBladeDirectives(BladeCompiler $bladeCompiler): void
  {
  $bladeCompiler->directive('boostJs', fn (): string => '<?php echo '.\Laravel\Boost\Services\BrowserLogger::class.'::getScript(); ?>');
  }
 
- private function hookIntoResponses(Router $router): void
+ protected function hookIntoResponses(Router $router): void
  {
  $this->app->booted(function () use ($router): void {
  $router->pushMiddlewareToGroup('web', InjectBoost::class);
  });
  }
 
- private function shouldRun(): bool
+ protected function shouldRun(): bool
  {
  if (! config('boost.enabled', true)) {
  return false;

src/Concerns/ReadsLogs.php

@@ -12,27 +12,27 @@ trait ReadsLogs
  * Regular expression fragments and default chunk-window sizes used when
  * scanning log files. Declaring them once keeps every consumer in sync.
  */
- private function getTimestampRegex(): string
+ protected function getTimestampRegex(): string
  {
  return '\\[\\d{4}-\\d{2}-\\d{2} \\d{2}:\\d{2}:\\d{2}\\]';
  }
 
- private function getEntrySplitRegex(): string
+ protected function getEntrySplitRegex(): string
  {
  return '/(?='.$this->getTimestampRegex().')/';
  }
 
- private function getErrorEntryRegex(): string
+ protected function getErrorEntryRegex(): string
  {
  return '/^'.$this->getTimestampRegex().'.*\\.ERROR:/';
  }
 
- private function getChunkSizeStart(): int
+ protected function getChunkSizeStart(): int
  {
  return 64 * 1024; // 64 kB
  }
 
- private function getChunkSizeMax(): int
+ protected function getChunkSizeMax(): int
  {
  return 1024 * 1024; // 1 MB
  }
@@ -114,7 +114,7 @@ protected function readLastErrorEntry(string $logFile): ?string
  *
  * @return string[]
  */
- private function scanLogChunkForEntries(string $logFile, int $chunkSize): array
+ protected function scanLogChunkForEntries(string $logFile, int $chunkSize): array
  {
  $fileSize = filesize($logFile);
  if ($fileSize === false) {

src/Console/InstallCommand.php

@@ -76,7 +76,7 @@ public function handle(CodeEnvironmentsDetector $codeEnvironmentsDetector, Herd
  $this->outro();
  }
 
- private function bootstrap(CodeEnvironmentsDetector $codeEnvironmentsDetector, Herd $herd, Terminal $terminal): void
+ protected function bootstrap(CodeEnvironmentsDetector $codeEnvironmentsDetector, Herd $herd, Terminal $terminal): void
  {
  $this->codeEnvironmentsDetector = $codeEnvironmentsDetector;
  $this->herd = $herd;
@@ -93,14 +93,14 @@ private function bootstrap(CodeEnvironmentsDetector $codeEnvironmentsDetector, H
  $this->projectName = config('app.name');
  }
 
- private function displayBoostHeader(): void
+ protected function displayBoostHeader(): void
  {
  note($this->boostLogo());
  intro('✦ Laravel Boost :: Install :: We Must Ship ✦');
  note("Let's give {$this->bgYellow($this->black($this->bold($this->projectName)))} a Boost");
  }
 
- private function boostLogo(): string
+ protected function boostLogo(): string
  {
  return
  <<<'HEADER'
@@ -113,21 +113,21 @@ private function boostLogo(): string
  HEADER;
  }
 
- private function discoverEnvironment(): void
+ protected function discoverEnvironment(): void
  {
  $this->systemInstalledCodeEnvironments = $this->codeEnvironmentsDetector->discoverSystemInstalledCodeEnvironments();
  $this->projectInstalledCodeEnvironments = $this->codeEnvironmentsDetector->discoverProjectInstalledCodeEnvironments(base_path());
  }
 
- private function collectInstallationPreferences(): void
+ protected function collectInstallationPreferences(): void
  {
  $this->selectedBoostFeatures = $this->selectBoostFeatures();
  $this->selectedTargetMcpClient = $this->selectTargetMcpClients();
  $this->selectedTargetAgents = $this->selectTargetAgents();
  $this->enforceTests = $this->determineTestEnforcement(ask: false);
  }
 
- private function performInstallation(): void
+ protected function performInstallation(): void
  {
  $this->installGuidelines();
 
@@ -138,7 +138,7 @@ private function performInstallation(): void
  }
  }
 
- private function discoverTools(): array
+ protected function discoverTools(): array
  {
  $tools = [];
  $toolDir = implode(DIRECTORY_SEPARATOR, [__DIR__, '..', 'Mcp', 'Tools']);
@@ -159,7 +159,7 @@ private function discoverTools(): array
  return $tools;
  }
 
- private function outro(): void
+ protected function outro(): void
  {
  $label = 'https://boost.laravel.com/installed';
 
@@ -189,7 +189,7 @@ private function outro(): void
  echo $this->black($this->bold($text.$link)).$this->reset(PHP_EOL).$this->reset(PHP_EOL);
  }
 
- private function hyperlink(string $label, string $url): string
+ protected function hyperlink(string $label, string $url): string
  {
  return "\033]8;;{$url}\007{$label}\033]8;;\033\\";
  }
@@ -230,7 +230,7 @@ protected function determineTestEnforcement(bool $ask = true): bool
  /**
  * @return Collection<int, string>
  */
- private function selectBoostFeatures(): Collection
+ protected function selectBoostFeatures(): Collection
  {
  $defaultInstallOptions = ['mcp_server', 'ai_guidelines'];
  $installOptions = [
@@ -272,7 +272,7 @@ protected function boostToolsToDisable(): array
  /**
  * @return Collection<int, CodeEnvironment>
  */
- private function selectTargetMcpClients(): Collection
+ protected function selectTargetMcpClients(): Collection
  {
  if (! $this->shouldInstallMcp() && ! $this->shouldInstallHerdMcp()) {
  return collect();
@@ -287,7 +287,7 @@ private function selectTargetMcpClients(): Collection
  /**
  * @return Collection<int, CodeEnvironment>
  */
- private function selectTargetAgents(): Collection
+ protected function selectTargetAgents(): Collection
  {
  if (! $this->shouldInstallAiGuidelines()) {
  return collect();
@@ -304,7 +304,7 @@ private function selectTargetAgents(): Collection
  *
  * @return array{scroll: int, required: bool, displayMethod: string}
  */
- private function getSelectionConfig(string $contractClass): array
+ protected function getSelectionConfig(string $contractClass): array
  {
  return match ($contractClass) {
  Agent::class => ['scroll' => 5, 'required' => false, 'displayMethod' => 'agentName'],
@@ -316,7 +316,7 @@ private function getSelectionConfig(string $contractClass): array
  /**
  * @return Collection<int, CodeEnvironment>
  */
- private function selectCodeEnvironments(string $contractClass, string $label): Collection
+ protected function selectCodeEnvironments(string $contractClass, string $label): Collection
  {
  $allEnvironments = $this->codeEnvironmentsDetector->getCodeEnvironments();
  $config = $this->getSelectionConfig($contractClass);
@@ -366,7 +366,7 @@ private function selectCodeEnvironments(string $contractClass, string $label): C
  return $selectedClasses->map(fn ($className) => $availableEnvironments->first(fn ($env): bool => $env::class === $className));
  }
 
- private function installGuidelines(): void
+ protected function installGuidelines(): void
  {
  if (! $this->shouldInstallAiGuidelines()) {
  return;
@@ -434,27 +434,27 @@ private function installGuidelines(): void
  }
  }
 
- private function shouldInstallAiGuidelines(): bool
+ protected function shouldInstallAiGuidelines(): bool
  {
  return $this->selectedBoostFeatures->contains('ai_guidelines');
  }
 
- private function shouldInstallStyleGuidelines(): bool
+ protected function shouldInstallStyleGuidelines(): bool
  {
  return false;
  }
 
- private function shouldInstallMcp(): bool
+ protected function shouldInstallMcp(): bool
  {
  return $this->selectedBoostFeatures->contains('mcp_server');
  }
 
- private function shouldInstallHerdMcp(): bool
+ protected function shouldInstallHerdMcp(): bool
  {
  return $this->selectedBoostFeatures->contains('herd_mcp');
  }
 
- private function installMcpServerConfig(): void
+ protected function installMcpServerConfig(): void
  {
  if (! $this->shouldInstallMcp() && ! $this->shouldInstallHerdMcp()) {
  return;
@@ -556,7 +556,7 @@ private function installMcpServerConfig(): void
  /**
  * Is the project actually using localization for their new features?
  */
- private function detectLocalization(): bool
+ protected function detectLocalization(): bool
  {
  $actuallyUsing = false;
 

src/Install/Detection/DetectionStrategyFactory.php

@@ -41,7 +41,7 @@ public function makeFromConfig(array $config): DetectionStrategy
  return $this->make($type, $config);
  }
 
- private function inferTypeFromConfig(array $config): string|array
+ protected function inferTypeFromConfig(array $config): string|array
  {
  $typeMap = [
  'files' => self::TYPE_FILE,

src/Install/Detection/DirectoryDetectionStrategy.php

@@ -38,7 +38,7 @@ public function detect(array $config, ?Platform $platform = null): bool
  return false;
  }
 
- private function expandPath(string $path, ?Platform $platform = null): string
+ protected function expandPath(string $path, ?Platform $platform = null): string
  {
  if ($platform === Platform::Windows) {
  return preg_replace_callback('/%([^%]+)%/', fn (array $matches) => getenv($matches[1]) ?: $matches[0], $path);
@@ -54,7 +54,7 @@ private function expandPath(string $path, ?Platform $platform = null): string
  return $path;
  }
 
- private function isAbsolutePath(string $path): bool
+ protected function isAbsolutePath(string $path): bool
  {
  return str_starts_with($path, '/') ||
  str_starts_with($path, '\\') ||

src/Install/GuidelineAssist.php

@@ -59,7 +59,7 @@ public function enums(): array
  *
  * @return array<string, string>
  */
- private function discover(callable $cb): array
+ protected function discover(callable $cb): array
  {
  $classes = [];
  $appPath = app_path();

src/Install/GuidelineComposer.php

@@ -247,7 +247,7 @@ protected function guideline(string $path): array
 
  private array $storedSnippets = [];
 
- private function processBoostSnippets(string $content): string
+ protected function processBoostSnippets(string $content): string
  {
  return preg_replace_callback('/(?<!@)@boostsnippet\(\s*(?P<nameQuote>[\'"])(?P<name>[^\1]*?)\1(?:\s*,\s*(?P<langQuote>[\'"])(?P<lang>[^\3]*?)\3)?\s*\)(?P<content>.*?)@endboostsnippet/s', function ($matches): string {
  $name = $matches['name'];

src/Install/GuidelineWriter.php

@@ -84,7 +84,7 @@ public function write(string $guidelines): int
  return $replaced ? self::REPLACED : self::NEW;
  }
 
- private function acquireLockWithRetry(mixed $handle, string $filePath, int $maxRetries = 3): void
+ protected function acquireLockWithRetry(mixed $handle, string $filePath, int $maxRetries = 3): void
  {
  $attempts = 0;
  $delay = 100000; // Start with 100ms in microseconds

src/Mcp/Tools/ListAvailableConfigKeys.php

@@ -36,7 +36,7 @@ public function handle(Request $request): Response
  * @param array<int|string, string|array<int|string, string>> $array
  * @return array<int|string, int|string>
  */
- private function flattenToDotNotation(array $array, string $prefix = ''): array
+ protected function flattenToDotNotation(array $array, string $prefix = ''): array
  {
  $results = [];
 

src/Mcp/Tools/ListRoutes.php

@@ -89,7 +89,7 @@ public function handle(Request $request): Response
  /**
  * @param array<string|bool> $options
  */
- private function artisan(string $command, array $options = []): string
+ protected function artisan(string $command, array $options = []): string
  {
  $output = new BufferedOutput;
  $response = Artisan::call($command, $options, $output);