Don't include mcp always (#273)

* feat: update laravel/roster constraint to 0.2.8 * feat: only include MCP guidelines if direct dependency Every Boost user would get the MCP guidelines because they have an indirect dependency on laravel/mcp. Users should only get the MCP guidelines if they _directly_ require laravel/mcp. * fix array shape on mustBeDirect * Fix Linting changes Signed-off-by: Pushpak Chhajed <pushpak1300@gmail.com> * Fix code styling * Formatting Signed-off-by: Pushpak Chhajed <pushpak1300@gmail.com> --------- Signed-off-by: Pushpak Chhajed <pushpak1300@gmail.com> Co-authored-by: Pushpak Chhajed <pushpak1300@gmail.com> Co-authored-by: pushpak1300 <31663512+pushpak1300@users.noreply.github.com>

Author: ashleyhindle

composer.json

@@ -21,7 +21,7 @@
  "illuminate/support": "^10.49.0|^11.45.3|^12.28.1",
  "laravel/mcp": "^0.2.0",
  "laravel/prompts": "0.1.25|^0.3.6",
- "laravel/roster": "^0.2.7"
+ "laravel/roster": "^0.2.8"
  },
  "require-dev": {
  "laravel/pint": "1.20",

src/Install/GuidelineComposer.php

@@ -7,6 +7,7 @@
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\Blade;
 use Laravel\Roster\Enums\Packages;
+use Laravel\Roster\Package;
 use Laravel\Roster\Roster;
 use Symfony\Component\Finder\Exception\DirectoryNotFoundException;
 use Symfony\Component\Finder\Finder;
@@ -30,6 +31,16 @@ class GuidelineComposer
  */
  protected array $packagePriorities;
 
+ /**
+ * Only include guidelines for these package names if they're a direct requirement.
+ * This fixes every Boost user getting the MCP guidelines due to indirect import.
+ *
+ * @var array<int, Packages>
+ * */
+ protected array $mustBeDirect = [
+ Packages::MCP,
+ ];
+
  public function __construct(protected Roster $roster, protected Herd $herd)
  {
  $this->packagePriorities = [
@@ -131,7 +142,7 @@ protected function find(): Collection
  // We don't add guidelines for packages unsupported by Roster right now
  foreach ($this->roster->packages() as $package) {
  // Skip packages that should be excluded due to priority rules
- if ($this->shouldExcludePackage($package->package()->value)) {
+ if ($this->shouldExcludePackage($package)) {
  continue;
  }
 
@@ -173,18 +184,18 @@ protected function find(): Collection
  /**
  * Determines if a package should be excluded from guidelines based on priority rules.
  */
- protected function shouldExcludePackage(string $packageName): bool
+ protected function shouldExcludePackage(Package $package): bool
  {
  foreach ($this->packagePriorities as $priorityPackage => $excludedPackages) {
- if (in_array($packageName, $excludedPackages, true)) {
+ if (in_array($package->package()->value, $excludedPackages, true)) {
  $priorityEnum = Packages::from($priorityPackage);
  if ($this->roster->uses($priorityEnum)) {
  return true;
  }
  }
  }
 
- return false;
+ return $package->indirect() && in_array($package->package(), $this->mustBeDirect, true);
  }
 
  /**

tests/Feature/Install/GuidelineComposerTest.php

@@ -316,6 +316,32 @@
  ->not->toContain('=== phpunit/core rules ===');
 });
 
+test('excludes laravel/mcp guidelines when indirectly required', function (): void {
+ $packages = new PackageCollection([
+ new Package(Packages::LARAVEL, 'laravel/framework', '11.0.0'),
+ (new Package(Packages::MCP, 'laravel/mcp', '0.2.2'))->setDirect(false),
+ ]);
+
+ $this->roster->shouldReceive('packages')->andReturn($packages);
+ $this->roster->shouldReceive('uses')->with(Packages::LARAVEL)->andReturn(true);
+ $this->roster->shouldReceive('uses')->with(Packages::MCP)->andReturn(true);
+
+ expect($this->composer->compose())->not->toContain('Mcp::web');
+});
+
+test('includes laravel/mcp guidelines when directly required', function (): void {
+ $packages = new PackageCollection([
+ new Package(Packages::LARAVEL, 'laravel/framework', '11.0.0'),
+ (new Package(Packages::MCP, 'laravel/mcp', '0.2.2'))->setDirect(true),
+ ]);
+
+ $this->roster->shouldReceive('packages')->andReturn($packages);
+ $this->roster->shouldReceive('uses')->with(Packages::LARAVEL)->andReturn(true);
+ $this->roster->shouldReceive('uses')->with(Packages::MCP)->andReturn(true);
+
+ expect($this->composer->compose())->toContain('Mcp::web');
+});
+
 test('includes PHPUnit guidelines when Pest is not present', function (): void {
  $packages = new PackageCollection([
  new Package(Packages::LARAVEL, 'laravel/framework', '11.0.0'),