Skip to content

Conversation

@fpingham
Copy link
Collaborator

@fpingham fpingham commented Feb 19, 2023

It is useful to be able to specify verbose or memory while still keeping the chain's overall structure.

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, do we need to pop these from kwargs?

@fpingham
Copy link
Collaborator Author

fpingham commented Feb 20, 2023

Probably more neat to pop them from kwargs , but I would do so in the _load_chain_from_file instead of in each chain's specific method since the same thing needs to be done for every specific chain. I'll push a commit to reflect this.

@hwchase17 hwchase17 merged commit 0b6a650 into langchain-ai:master Feb 21, 2023
@blob42 blob42 mentioned this pull request Feb 21, 2023
zachschillaci27 pushed a commit to zachschillaci27/langchain that referenced this pull request Mar 8, 2023
langchain-ai#1153) It is useful to be able to specify `verbose` or `memory` while still keeping the chain's overall structure. --------- Co-authored-by: Francisco Ingham <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants