This repository was archived by the owner on May 22, 2020. It is now read-only.
Enable end-user customization of manifest files in docker-multinode #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| Can't really use the docker-multinode setup for anything other than a test environment without this ability. Thanks for your work, @cheld |
This was referenced Feb 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I added a simple way to customize the docker-multinode provisioning.
First, a new script copies the manifest files from container to host. The user can customize them as needed.
Then these files are mounted when kubelet is started. The addon manager must be adapted as well to read from host. Separate PR kubernetes/kubernetes#32578
I tried to make the UX simple. It seemed best to always read from host instead of providing a switch.
Would fix
#215
and beneficial to more issues like
#216
#195