Skip to content

Commit ecbe1a3

Browse files
Merge pull request #134230 from Jefftree/agg-v2beta1-lock
Lock AggregatedDiscoveryRemoveBetaType to true Kubernetes-commit: 6bcac876f841bd9a49f961620d2d2134c908f7d8
2 parents f661bed + 29cd2ee commit ecbe1a3

File tree

5 files changed

+8
-3
lines changed

5 files changed

+8
-3
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ require (
5050
gopkg.in/natefinch/lumberjack.v2 v2.2.1
5151
k8s.io/api v0.0.0-20251105015405-dd26ad10fd6e
5252
k8s.io/apimachinery v0.0.0-20251104194212-729c13d7df38
53-
k8s.io/client-go v0.0.0-20251105003230-5aa3ca7f2ac5
53+
k8s.io/client-go v0.0.0-20251105163311-7d09f53b04bd
5454
k8s.io/component-base v0.0.0-20251105043606-09c454e1f74b
5555
k8s.io/klog/v2 v2.130.1
5656
k8s.io/kms v0.0.0-20251031154137-67fac28309db

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -303,8 +303,8 @@ k8s.io/api v0.0.0-20251105015405-dd26ad10fd6e h1:mo0m8qt3RGonvE9QzGm1NXcsb7ht6AI
303303
k8s.io/api v0.0.0-20251105015405-dd26ad10fd6e/go.mod h1:WAtHXlm214kKcYg1bP2G5eefhLoi/NCF6sxUeTjUXMs=
304304
k8s.io/apimachinery v0.0.0-20251104194212-729c13d7df38 h1:5jRAlNQwmLaPNhf9mfhacvZKFF8fE4nfULiBul0PrGM=
305305
k8s.io/apimachinery v0.0.0-20251104194212-729c13d7df38/go.mod h1:dR9KPaf5L0t2p9jZg/wCGB4b3ma2sXZ2zdNqILs+Sak=
306-
k8s.io/client-go v0.0.0-20251105003230-5aa3ca7f2ac5 h1:zfG89yYdzEweXvymwXD810niLOIvcKD0qq67yJVKxbQ=
307-
k8s.io/client-go v0.0.0-20251105003230-5aa3ca7f2ac5/go.mod h1:0nAtsAwkk8yBzjuzDlbrxZghpDWfhA2alzTAVP+GyyM=
306+
k8s.io/client-go v0.0.0-20251105163311-7d09f53b04bd h1:3i087DvI/zJ9Vl4YdVq1A4h5HoJMHlNTmiHKWdJOQ8A=
307+
k8s.io/client-go v0.0.0-20251105163311-7d09f53b04bd/go.mod h1:aSLSvCyHgh6llJnMW07M1FzR6u6WJG5HBG3v3OwfqLg=
308308
k8s.io/component-base v0.0.0-20251105043606-09c454e1f74b h1:iZ59BHeRkNAM5RSutSryNx9qtrgT7YPSM5HanS+GXVw=
309309
k8s.io/component-base v0.0.0-20251105043606-09c454e1f74b/go.mod h1:ccVXlbwyM8koWd6+OylPWi8m3aunkoPzcQcSbVvTHrk=
310310
k8s.io/klog/v2 v2.130.1 h1:n9Xl7H1Xvksem4KFG4PYbdQCQxqc/tTUyrgXaOhHSzk=

pkg/endpoints/discovery/aggregated/handler_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ import (
3939
"k8s.io/apimachinery/pkg/runtime/schema"
4040
runtimeserializer "k8s.io/apimachinery/pkg/runtime/serializer"
4141
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
42+
utilversion "k8s.io/apimachinery/pkg/util/version"
4243
"k8s.io/apimachinery/pkg/version"
4344
apidiscoveryv2conversion "k8s.io/apiserver/pkg/apis/apidiscovery/v2"
4445
discoveryendpoint "k8s.io/apiserver/pkg/endpoints/discovery/aggregated"
@@ -190,6 +191,7 @@ func TestBasicResponseProtobuf(t *testing.T) {
190191

191192
// V2Beta1 should still be served
192193
func TestV2Beta1SkewSupport(t *testing.T) {
194+
featuregatetesting.SetFeatureGateEmulationVersionDuringTest(t, utilfeature.DefaultFeatureGate, utilversion.MustParse("1.34"))
193195
featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, genericfeatures.AggregatedDiscoveryRemoveBetaType, false)
194196
manager := discoveryendpoint.NewResourceManager("apis")
195197

pkg/endpoints/discovery/aggregated/wrapper_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import (
2424
"testing"
2525

2626
"github.com/stretchr/testify/assert"
27+
"k8s.io/apimachinery/pkg/util/version"
2728
"k8s.io/apiserver/pkg/endpoints/request"
2829
genericfeatures "k8s.io/apiserver/pkg/features"
2930
utilfeature "k8s.io/apiserver/pkg/util/feature"
@@ -61,6 +62,7 @@ func (f fakeHTTPHandler) ServeHTTP(resp http.ResponseWriter, req *http.Request)
6162
}
6263

6364
func TestAggregationEnabled(t *testing.T) {
65+
featuregatetesting.SetFeatureGateEmulationVersionDuringTest(t, utilfeature.DefaultFeatureGate, version.MustParse("1.34"))
6466
unaggregated := fakeHTTPHandler{data: "unaggregated"}
6567
aggregated := fakeHTTPHandler{data: "aggregated"}
6668
wrapped := WrapAggregatedDiscoveryToHandler(unaggregated, aggregated)

pkg/features/kube_features.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@ var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate
325325
AggregatedDiscoveryRemoveBetaType: {
326326
{Version: version.MustParse("1.0"), Default: false, PreRelease: featuregate.GA},
327327
{Version: version.MustParse("1.33"), Default: true, PreRelease: featuregate.Deprecated},
328+
{Version: version.MustParse("1.35"), Default: true, PreRelease: featuregate.Deprecated, LockToDefault: true},
328329
},
329330

330331
AllowParsingUserUIDFromCertAuth: {

0 commit comments

Comments
 (0)