Review Remarks

Author: trasc

pkg/webhook/admission/defaulter_custom.go

@@ -140,7 +140,10 @@ func (h *defaulterForType) dropSchemeRemovals(r Response, original runtime.Objec
 return Errored(http.StatusInternalServerError, err)
 }
 
-patchOriginal := PatchResponseFromRaw(raw, marshalledOriginal).Patches
+patchOriginal, err := jsonpatch.CreatePatch(raw, marshalledOriginal)
+if err != nil {
+return Errored(http.StatusInternalServerError, err)
+}
 removedByScheme := sets.New(slices.DeleteFunc(patchOriginal, func(p jsonpatch.JsonPatchOperation) bool { return p.Operation != opRemove })...)
 
 r.Patches = slices.DeleteFunc(r.Patches, func(p jsonpatch.JsonPatchOperation) bool {

pkg/webhook/admission/defaulter_custom_test.go

@@ -29,7 +29,7 @@ import (
 
 var _ = Describe("Defaulter Handler", func() {
 
-It("should not preserve unknown fields by default", func() {
+It("should remove unknown fields when DefaulterRemoveUnknownFields is passed", func() {
 obj := &TestDefaulter{}
 handler := WithCustomDefaulter(admissionScheme, obj, &TestCustomDefaulter{}, DefaulterRemoveUnknownFields)
 
@@ -61,7 +61,7 @@ var _ = Describe("Defaulter Handler", func() {
 Expect(resp.Result.Code).Should(Equal(int32(http.StatusOK)))
 })
 
-It("should preserve unknown fields when DefaulterPreserveUnknownFields is passed", func() {
+It("should preserve unknown fields by default", func() {
 obj := &TestDefaulter{}
 handler := WithCustomDefaulter(admissionScheme, obj, &TestCustomDefaulter{})