bug symfony#61855 [DoctrineBridge][Yaml] don't cast strings exceeding the min/max int ranges (xabbuh)

This PR was merged into the 6.4 branch. Discussion ---------- [DoctrineBridge][Yaml] don't cast strings exceeding the min/max int ranges | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT see php/php-src#19760 and https://wiki.php.net/rfc/warnings-php-8-5#casting_out_of_range_floats_to_int Commits ------- bac84d1 don't cast strings exceeding the min/max int ranges

Author: nicolas-grekas

src/Symfony/Bridge/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php

@@ -67,7 +67,7 @@ public function getEntitiesByIds(string $identifier, array $values): array
 
  // Filter out non-integer values (e.g. ""). If we don't, some
  // databases such as PostgreSQL fail.
- $values = array_values(array_filter($values, fn ($v) => (string) $v === (string) (int) $v || ctype_digit($v)));
+ $values = array_values(array_filter($values, static fn ($v) => \is_string($v) && ctype_digit($v) || (string) $v === (string) (int) $v));
  } elseif (\in_array($type, ['ulid', 'uuid', 'guid'])) {
  $parameterType = class_exists(ArrayParameterType::class) ? ArrayParameterType::STRING : Connection::PARAM_STR_ARRAY;
 

src/Symfony/Component/Yaml/Inline.php

@@ -701,6 +701,10 @@ private static function evaluateScalar(string $scalar, int $flags, array &$refer
  switch (true) {
  case ctype_digit($scalar):
  case '-' === $scalar[0] && ctype_digit(substr($scalar, 1)):
+ if ($scalar < \PHP_INT_MIN || \PHP_INT_MAX < $scalar) {
+ return $scalar;
+ }
+
  $cast = (int) $scalar;
 
  return ($scalar === (string) $cast) ? $cast : $scalar;