Skip to content

Commit 7d46dc9

Browse files
committed
Fix failing tests.
1 parent 8eda738 commit 7d46dc9

File tree

5 files changed

+20
-5
lines changed

5 files changed

+20
-5
lines changed

app/src/main/kotlin/com/fernandocejas/sample/features/movies/Movie.kt

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,11 @@
1515
*/
1616
package com.fernandocejas.sample.features.movies
1717

18-
data class Movie(val id: Int, val poster: String)
18+
import com.fernandocejas.sample.core.extension.empty
19+
20+
data class Movie(val id: Int, val poster: String) {
21+
22+
companion object {
23+
val empty = Movie(0, String.empty())
24+
}
25+
}

app/src/main/kotlin/com/fernandocejas/sample/features/movies/MovieDetails.kt

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,19 @@
1515
*/
1616
package com.fernandocejas.sample.features.movies
1717

18+
import com.fernandocejas.sample.core.extension.empty
19+
1820
data class MovieDetails(val id: Int,
1921
val title: String,
2022
val poster: String,
2123
val summary: String,
2224
val cast: String,
2325
val director: String,
2426
val year: Int,
25-
val trailer: String)
27+
val trailer: String) {
28+
29+
companion object {
30+
val empty = MovieDetails(0, String.empty(), String.empty(), String.empty(),
31+
String.empty(), String.empty(), 0, String.empty())
32+
}
33+
}

app/src/test/kotlin/com/fernandocejas/sample/features/movies/GetMovieDetailsTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class GetMovieDetailsTest : UnitTest() {
3232

3333
@Before fun setUp() {
3434
getMovieDetails = GetMovieDetails(moviesRepository)
35-
every { moviesRepository.movieDetails(MOVIE_ID) } returns Right(MovieDetails.empty())
35+
every { moviesRepository.movieDetails(MOVIE_ID) } returns Right(MovieDetails.empty)
3636
}
3737

3838
@Test fun `should get data from repository`() {

app/src/test/kotlin/com/fernandocejas/sample/features/movies/GetMoviesTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class GetMoviesTest : UnitTest() {
3333

3434
@Before fun setUp() {
3535
getMovies = GetMovies(moviesRepository)
36-
every { moviesRepository.movies() } returns Right(listOf(Movie.empty()))
36+
every { moviesRepository.movies() } returns Right(listOf(Movie.empty))
3737
}
3838

3939
@Test fun `should get data from repository`() {

app/src/test/kotlin/com/fernandocejas/sample/features/movies/MoviesRepositoryTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ class MoviesRepositoryTest : UnitTest() {
121121

122122
val movieDetails = networkRepository.movieDetails(1)
123123

124-
movieDetails shouldEqual Right(MovieDetails.empty())
124+
movieDetails shouldEqual Right(MovieDetails.empty)
125125
verify(exactly = 1) { service.movieDetails(1) }
126126
}
127127

0 commit comments

Comments
 (0)