refactor: renamed token accreditedLawyerToken into accreditedProfessionalToken

Author: jaybuidl

contracts/src/arbitration/dispute-kits/DisputeKitGatedArgentinaConsumerProtection.sol

@@ -15,7 +15,7 @@ interface IBalanceHolder {
 
 /// @title DisputeKitGatedArgentinaConsumerProtection
 /// @notice Dispute kit implementation adapted from DisputeKitClassic
-/// - a drawing system: proportional to staked PNK among the jurors holding a `accreditedLawyerToken` or a `accreditedConsumerProtectionLawyerToken`
+/// - a drawing system: proportional to staked PNK among the jurors holding a `accreditedProfessionalToken` or a `accreditedConsumerProtectionLawyerToken`
 /// and at least one of the drawn jurors is holding a `accreditedConsumerProtectionLawyerToken`,
 /// - a vote aggregation system: plurality,
 /// - an incentive system: equal split between coherent votes,
@@ -27,7 +27,7 @@ contract DisputeKitGatedArgentinaConsumerProtection is DisputeKitClassicBase {
  // * Storage * //
  // ************************************* //
 
- address public accreditedLawyerToken; // The address of the accredited lawyer token.
+ address public accreditedProfessionalToken; // The address of the accredited professional token.
  address public accreditedConsumerProtectionLawyerToken; // The address of the accredited consumer protection lawyer token.
  mapping(uint256 localDisputeID => mapping(uint256 localRoundID => bool)) public drawnConsumerProtectionLawyer; // Maps the local dispute and round ID to the boolean indicating if the consumer protection lawyer was drawn.
 
@@ -44,17 +44,17 @@ contract DisputeKitGatedArgentinaConsumerProtection is DisputeKitClassicBase {
  /// @param _owner The owner's address.
  /// @param _core The KlerosCore arbitrator.
  /// @param _wNative The wrapped native token address, typically wETH.
- /// @param _accreditedLawyerToken The address of the accredited lawyer token.
+ /// @param _accreditedProfessionalToken The address of the accredited professional token.
  /// @param _accreditedConsumerProtectionLawyerToken The address of the accredited consumer protection lawyer token.
  function initialize(
  address _owner,
  KlerosCore _core,
  address _wNative,
- address _accreditedLawyerToken,
+ address _accreditedProfessionalToken,
  address _accreditedConsumerProtectionLawyerToken
  ) external initializer {
  __DisputeKitClassicBase_initialize(_owner, _core, _wNative);
- accreditedLawyerToken = _accreditedLawyerToken;
+ accreditedProfessionalToken = _accreditedProfessionalToken;
  accreditedConsumerProtectionLawyerToken = _accreditedConsumerProtectionLawyerToken;
  }
 
@@ -68,10 +68,10 @@ contract DisputeKitGatedArgentinaConsumerProtection is DisputeKitClassicBase {
  // NOP
  }
 
- /// @notice Changes the accredited lawyer token.
- /// @param _accreditedLawyerToken The address of the accredited lawyer token.
- function changeAccreditedLawyerToken(address _accreditedLawyerToken) external onlyByOwner {
- accreditedLawyerToken = _accreditedLawyerToken;
+ /// @notice Changes the accredited professional token.
+ /// @param _accreditedProfessionalToken The address of the accredited lawyer token.
+ function changeAccreditedProfessionalToken(address _accreditedProfessionalToken) external onlyByOwner {
+ accreditedProfessionalToken = _accreditedProfessionalToken;
  }
 
  /// @notice Changes the accredited consumer protection lawyer token.
@@ -129,7 +129,7 @@ contract DisputeKitGatedArgentinaConsumerProtection is DisputeKitClassicBase {
  // Reject this draw so that another iteration can try again later.
  return false;
  }
- if (IBalanceHolder(accreditedLawyerToken).balanceOf(_juror) == 0) {
+ if (IBalanceHolder(accreditedProfessionalToken).balanceOf(_juror) == 0) {
  // The juror does not hold either of the tokens.
  return false;
  }

contracts/test/foundry/DisputeKitGatedArgentinaConsumerProtection_Drawing.t.sol

@@ -14,23 +14,23 @@ import "../../src/libraries/Constants.sol";
 /// @title DisputeKitGatedArgentinaConsumerProtection_DrawingTest
 /// @dev Tests for DisputeKitGatedArgentinaConsumerProtection drawing logic
 /// This dispute kit requires:
-/// - Jurors must own either accreditedLawyerToken OR accreditedConsumerProtectionLawyerToken
+/// - Jurors must own either accreditedProfessionalToken OR accreditedConsumerProtectionLawyerToken
 /// - Each round must have at least one juror with accreditedConsumerProtectionLawyerToken
 contract DisputeKitGatedArgentinaConsumerProtection_DrawingTest is KlerosCore_TestBase {
  // ************************************* //
  // * Test Contracts * //
  // ************************************* //
 
  DisputeKitGatedArgentinaConsumerProtection argentinaDK;
- TestERC721 accreditedLawyerToken;
+ TestERC721 accreditedProfessionalToken;
  TestERC721 accreditedConsumerProtectionLawyerToken;
 
  // ************************************* //
  // * Test Accounts * //
  // ************************************* //
 
- address lawyer1; // Has only accredited lawyer token
- address lawyer2; // Has only accredited lawyer token
+ address lawyer1; // Has only accredited professional token
+ address lawyer2; // Has only accredited professional token
  address consumerLawyer1; // Has only consumer protection lawyer token
  address consumerLawyer2; // Has only consumer protection lawyer token
  address bothLawyer; // Has both tokens
@@ -56,7 +56,7 @@ contract DisputeKitGatedArgentinaConsumerProtection_DrawingTest is KlerosCore_Te
  noTokenJuror = vm.addr(15);
 
  // Deploy token contracts
- accreditedLawyerToken = new TestERC721("Accredited Lawyer", "AL");
+ accreditedProfessionalToken = new TestERC721("Accredited Lawyer", "AL");
  accreditedConsumerProtectionLawyerToken = new TestERC721("Consumer Protection Lawyer", "CPL");
 
  // Deploy and initialize the Argentina dispute kit
@@ -66,7 +66,7 @@ contract DisputeKitGatedArgentinaConsumerProtection_DrawingTest is KlerosCore_Te
  owner,
  address(core),
  address(wNative),
- address(accreditedLawyerToken),
+ address(accreditedProfessionalToken),
  address(accreditedConsumerProtectionLawyerToken)
  );
  UUPSProxy proxyDK = new UUPSProxy(address(dkLogic), initData);
@@ -173,8 +173,8 @@ contract DisputeKitGatedArgentinaConsumerProtection_DrawingTest is KlerosCore_Te
  /// Expected: Drawing never completes all required jurors due to last-iteration rejection logic
  function test_drawFailsWithOnlyAccreditedLawyers() public {
  // Mint accredited lawyer tokens (but NOT consumer protection tokens)
- accreditedLawyerToken.safeMint(lawyer1);
- accreditedLawyerToken.safeMint(lawyer2);
+ accreditedProfessionalToken.safeMint(lawyer1);
+ accreditedProfessionalToken.safeMint(lawyer2);
 
  // Stake in the Argentina court
  vm.prank(lawyer1);
@@ -246,8 +246,8 @@ contract DisputeKitGatedArgentinaConsumerProtection_DrawingTest is KlerosCore_Te
  /// @notice Test that drawing succeeds with a mix of both lawyer types
  function test_drawSucceedsWithMixedLawyers() public {
  // Mint tokens to different jurors
- accreditedLawyerToken.safeMint(lawyer1);
- accreditedLawyerToken.safeMint(lawyer2);
+ accreditedProfessionalToken.safeMint(lawyer1);
+ accreditedProfessionalToken.safeMint(lawyer2);
  accreditedConsumerProtectionLawyerToken.safeMint(consumerLawyer1);
 
  // Stake in the Argentina court
@@ -287,7 +287,7 @@ contract DisputeKitGatedArgentinaConsumerProtection_DrawingTest is KlerosCore_Te
  /// @notice Test drawing when a juror holds both token types
  function test_drawWithJurorHoldingBothTokens() public {
  // Mint both tokens to the same juror
- accreditedLawyerToken.safeMint(bothLawyer);
+ accreditedProfessionalToken.safeMint(bothLawyer);
  accreditedConsumerProtectionLawyerToken.safeMint(bothLawyer);
 
  // Stake in the Argentina court
@@ -365,7 +365,7 @@ contract DisputeKitGatedArgentinaConsumerProtection_DrawingTest is KlerosCore_Te
  /// @notice Test that each round independently satisfies the consumer protection lawyer requirement
  function test_multipleRoundsRequirement() public {
  // Mint tokens
- accreditedLawyerToken.safeMint(lawyer1);
+ accreditedProfessionalToken.safeMint(lawyer1);
  accreditedConsumerProtectionLawyerToken.safeMint(consumerLawyer1);
 
  // Stake in the Argentina court