fix: coderabbit review, fixed a test not making any assertions

Author: jaybuidl

contracts/src/test/DisputeKitGatedMock.sol

@@ -4,8 +4,8 @@ pragma solidity ^0.8.24;
 
 import "../arbitration/dispute-kits/DisputeKitGated.sol";
 
-/// @title KlerosCoreMock
-/// KlerosCore with view functions to use in Foundry tests.
+/// @title DisputeKitGatedMock
+/// DisputeKitGated with view functions to use in the tests.
 contract DisputeKitGatedMock is DisputeKitGated {
  function extraDataToTokenInfo(
  bytes memory _extraData

contracts/src/test/DisputeKitGatedShutterMock.sol

@@ -5,7 +5,7 @@ pragma solidity ^0.8.24;
 import "../arbitration/dispute-kits/DisputeKitGatedShutter.sol";
 
 /// @title DisputeKitGatedShutterMock
-/// DisputeKitGatedShutter with view functions to use in Foundry tests.
+/// DisputeKitGatedShutter with view functions to use in the tests.
 contract DisputeKitGatedShutterMock is DisputeKitGatedShutter {
  function extraDataToTokenInfo(
  bytes memory _extraData

contracts/test/arbitration/helpers/dispute-kit-gated-common.ts

@@ -229,7 +229,7 @@ export async function setupTokenGatedTest(config: TokenGatedTestConfig): Promise
  PNK: PNK_AMOUNT,
  };
 
- // Whitelist all tokens by default to make existing tests work
+ // Whitelist all tokens by default
  await whitelistTokens(context, [dai.target, nft721.target, nft1155.target], true);
 
  return context;
@@ -390,7 +390,7 @@ export function testERC20Gating(context: () => TokenGatedTestContext) {
 
  it("Should draw only the jurors who have some DAI balance", async () => {
  const ctx = context();
- ctx.dai.transfer(ctx.juror1.address, 1);
+ await ctx.dai.transfer(ctx.juror1.address, 1);
 
  const nbOfJurors = 15n;
  const tx = await stakeAndDraw(

contracts/test/arbitration/helpers/dispute-kit-shutter-common.ts

@@ -731,26 +731,31 @@ export function testRecoveryFlowJurorReveals(context: () => ShutterTestContext)
 
 export function testHashFunctionBehavior(context: () => ShutterTestContext) {
  describe("Hash Function Behavior", () => {
- it("Should return different hashes for juror vs non-juror callers", async () => {
+ it("Should compute different hashes for juror recovery vs non-juror normal flow", async () => {
  const ctx = context();
- const disputeId = await createDisputeAndDraw(ctx, ctx.shutterCourtID, 3, ctx.shutterDKID);
- await advanceToCommitPeriod(ctx, disputeId);
 
- const voteIDs = await getVoteIDsForJuror(ctx, disputeId, ctx.juror1);
+ // Test 1: Verify hashVote matches generateCommitments for non-juror case
  const { fullCommit, recoveryCommit } = generateCommitments(ctx.choice, ctx.salt, ctx.justification);
+ const nonJurorHash = await ctx.disputeKit.hashVote(ctx.choice, ctx.salt, ctx.justification);
+ expect(nonJurorHash).to.equal(fullCommit, "Non-juror hash should match full commitment");
 
- await ctx.disputeKit
- .connect(ctx.juror1)
- .castCommitShutter(disputeId, voteIDs, fullCommit, recoveryCommit, ctx.identity, ctx.encryptedVote);
+ // Test 2: Verify the two commitment types are different
+ expect(fullCommit).to.not.equal(recoveryCommit, "Full and recovery commitments should differ");
 
- await advanceToVotePeriod(ctx, disputeId);
+ // Test 3: Calculate what the juror hash would be and verify it matches recovery commitment
+ const jurorExpectedHash = ethers.keccak256(
+ ethers.AbiCoder.defaultAbiCoder().encode(["uint256", "uint256"], [ctx.choice, ctx.salt])
+ );
+ expect(jurorExpectedHash).to.equal(recoveryCommit, "Juror hash calculation should match recovery commitment");
 
- // During castVoteShutter, the contract should use different hash logic
- // For juror: hash(choice, salt)
- // For non-juror: hash(choice, salt, justificationHash)
+ // Test 4: Verify that changing justification affects non-juror hash but not juror hash
+ const differentJustification = "Different justification";
+ const { fullCommit: newFullCommit } = generateCommitments(ctx.choice, ctx.salt, differentJustification);
+ const newNonJurorHash = await ctx.disputeKit.hashVote(ctx.choice, ctx.salt, differentJustification);
 
- // This is tested implicitly by the recovery flow tests above
- // The juror can reveal with any justification, while non-juror must provide exact justification
+ expect(newNonJurorHash).to.equal(newFullCommit, "New non-juror hash should match new full commitment");
+ expect(newNonJurorHash).to.not.equal(nonJurorHash, "Non-juror hash should change with justification");
+ // Note: juror hash would remain the same (recoveryCommit) regardless of justification
  });
 
  it("Should correctly compute hash for normal flow", async () => {