Skip to content

Commit 4eaca66

Browse files
committed
fix bug where refresh could run twice when opening cov overview
1 parent 4e8f5d3 commit 4eaca66

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

plugin/lighthouse/director.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1401,7 +1401,8 @@ def _refresh(self):
14011401
await_future(future)
14021402

14031403
# (re) map each set of loaded coverage data to the database
1404-
self._refresh_database_coverage()
1404+
if self.coverage_names:
1405+
self._refresh_database_coverage()
14051406

14061407
# notify of full-refresh
14071408
self._notify_refreshed()

plugin/lighthouse/ui/coverage_overview.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,7 @@ class EventProxy(QtCore.QObject):
264264
def __init__(self, target):
265265
super(EventProxy, self).__init__()
266266
self._target = weakref.proxy(target)
267+
self._first_hit = True
267268

268269
def eventFilter(self, source, event):
269270

@@ -304,10 +305,15 @@ def eventFilter(self, source, event):
304305
#
305306

306307
elif int(event.type()) == self.EventUpdateLater:
307-
if self._target.visible and not self._target.director.metadata.cached:
308+
309+
if self._target.visible and self._first_hit:
310+
self._first_hit = False
311+
308312
if disassembler.NAME == "BINJA":
309313
self._target.lctx.start()
310-
self._target.director.refresh()
314+
315+
if not self._target.director.metadata.cached:
316+
self._target.director.refresh()
311317

312318
#
313319
# this is an unknown event, but it seems to fire when the widget is

0 commit comments

Comments
 (0)