compare Module instances

I want to compare if a meta entry's module is the same as a module I have. The comparison is implemented on the value of lys_module*. It seems that successive calls to ly_ctx_get_module always return the same pointer so it *should* be safe. However, same modules in different contexts compare as not equal. Change-Id: I96efca783d5e780e98693330803e73847151d7af

Author: peckato1

include/libyang-cpp/Module.hpp

@@ -89,6 +89,8 @@ class LIBYANG_CPP_EXPORT Module {
 
  std::string printStr(const SchemaOutputFormat format, const std::optional<SchemaPrintFlags> flags = std::nullopt, std::optional<size_t> lineLength = std::nullopt) const;
 
+ bool operator==(const Module& other) const;
+
  friend Context;
  friend DataNode;
  friend Meta;

src/Module.cpp

@@ -231,6 +231,11 @@ std::string Module::printStr(const SchemaOutputFormat format, const std::optiona
  return printModule(lys_print_module, m_module, format, flags, lineLength, "lys_print_module");
 }
 
+bool Module::operator==(const Module& other) const
+{
+ return m_module == other.m_module;
+}
+
 SubmoduleParsed::SubmoduleParsed(const lysp_submodule* submodule, std::shared_ptr<ly_ctx> ctx)
  : m_ctx(ctx)
  , m_submodule(submodule)

tests/context.cpp

@@ -369,6 +369,25 @@ TEST_CASE("context")
  REQUIRE(modules.at(7).revision() == std::nullopt);
  }
 
+ DOCTEST_SUBCASE("Module comparison")
+ {
+ ctx->setSearchDir(TESTS_DIR / "yang");
+ auto mod = ctx->loadModule("mod1", std::nullopt, {});
+
+ DOCTEST_SUBCASE("Same module loaded later")
+ {
+ REQUIRE(mod == ctx->loadModule("mod1", std::nullopt, {}));
+ }
+
+ DOCTEST_SUBCASE("Same module, different contexts")
+ {
+ std::optional<libyang::Context> ctx2{std::in_place, std::nullopt, libyang::ContextOptions::NoYangLibrary | libyang::ContextOptions::DisableSearchCwd};
+ ctx2->setSearchDir(TESTS_DIR / "yang");
+
+ REQUIRE(mod != ctx2->loadModule("mod1", std::nullopt, {}));
+ }
+ }
+
  DOCTEST_SUBCASE("Context::registerModuleCallback")
  {
  auto numCalled = 0;