Skip to content

Commit 23a7914

Browse files
committed
Explicitly configure the port for catalogue to be 80 in kubernetes/manifests
In case one was to fork this repository and pass arbitrary arguments without passing `-port=80`, `catalogue` would then suddenly no longer work, as: - `catalogue` defaults to `8081`: https://github.com/microservices-demo/catalogue/blob/0.3.5/cmd/cataloguesvc/main.go#L44 - the default override in `Dockerfile` would then be lost: https://github.com/microservices-demo/catalogue/blob/0.3.5/docker/catalogue/Dockerfile#L12 - `/health` therefore wouldn't be reachable on `80` (but `8081`) - Kubernetes therefore wouldn't route traffic to `catalogue`
1 parent 6717116 commit 23a7914

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

deploy/kubernetes/manifests/catalogue-dep.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ spec:
1616
containers:
1717
- name: catalogue
1818
image: weaveworksdemos/catalogue:0.3.5
19+
args:
20+
- -port=80
1921
resources:
2022
limits:
2123
cpu: 100m

0 commit comments

Comments
 (0)