Skip to content

Commit 7bee251

Browse files
committed
more fixes to tests
1 parent 7750ed1 commit 7bee251

File tree

4 files changed

+5
-3
lines changed

4 files changed

+5
-3
lines changed

src/test/extension.jupyter.comms.jupyterClient.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -542,6 +542,7 @@ suite('JupyterClient', () => {
542542
output.push(data);
543543
}, reason => {
544544
assert.fail(reason, null, 'Code execution failed in jupyter', '');
545+
done();
545546
}, () => {
546547
assert.equal(output.some(d => d.stream === 'pyout' && d.type === 'text' && d.data['text/plain'] === '3'), true, 'pyout not found in output');
547548
assert.equal(output.some(d => d.stream === 'status' && d.type === 'text' && d.data === 'ok'), true, 'status not found in output');

src/test/extension.jupyter.comms.jupyterKernel.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ suite('Jupyter Kernel', () => {
9292
}
9393
});
9494
});
95-
suiteTeardown(done => {
95+
suiteTeardown(() => {
9696
disposable.dispose();
9797
});
9898

@@ -376,6 +376,7 @@ suite('Jupyter Kernel', () => {
376376
output.push(data);
377377
}, reason => {
378378
assert.fail(reason, null, 'Code execution failed in jupyter', '');
379+
done();
379380
}, () => {
380381
assert.equal(output.some(d => d.stream === 'pyout' && d.type === 'text' && d.data['text/plain'] === '3'), true, 'pyout not found in output');
381382
assert.equal(output.some(d => d.stream === 'status' && d.type === 'text' && d.data === 'ok'), true, 'status not found in output');

src/test/extension.jupyter.comms.jupyterKernelManager.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ suite('Kernel Manager', () => {
6767
done();
6868
});
6969
});
70-
suiteTeardown(done => {
70+
suiteTeardown(() => {
7171
disposable.dispose();
7272
});
7373
setup(() => {

src/test/initialize.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export const TEST_TIMEOUT = 25000;
6565
function getPythonPath(): string {
6666
const pythonPaths = ['/home/travis/virtualenv/python3.5.2/bin/python',
6767
'/Users/travis/.pyenv/versions/3.5.1/envs/MYVERSION/bin/python',
68-
'/Users/donjayamanne/Projects/PythonEnvs/p361/bin/python',
68+
'/xUsers/donjayamanne/Projects/PythonEnvs/p361/bin/python',
6969
'/Users/donjayamanne/Projects/PythonEnvs/p27/bin/python'];
7070
for (let counter = 0; counter < pythonPaths.length; counter++) {
7171
if (fs.existsSync(pythonPaths[counter])) {

0 commit comments

Comments
 (0)