Merge pull request #93 from kdroidFilter/fix-Overlay-not-filling-max-Height-#83

Fix: Ensure Video Player Overlay Takes Full Height Across All Platforms

Author: kdroidFilter

mediaplayer/src/androidMain/kotlin/io/github/kdroidfilter/composemediaplayer/VideoPlayerSurface.android.kt

@@ -157,7 +157,10 @@ private fun VideoPlayerContent(
  }
  }
 
- // Render the overlay content on top of the video
- overlay()
+ // Render the overlay content on top of the video with fillMaxSize modifier
+ // to ensure it takes the full height of the parent Box
+ Box(modifier = Modifier.fillMaxSize()) {
+ overlay()
+ }
  }
 }

mediaplayer/src/iosMain/kotlin/io/github/kdroidfilter/composemediaplayer/VideoPlayerSurface.ios.kt

@@ -3,6 +3,7 @@
 package io.github.kdroidfilter.composemediaplayer
 
 import androidx.compose.foundation.layout.Box
+import androidx.compose.foundation.layout.fillMaxSize
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.DisposableEffect
 import androidx.compose.runtime.remember
@@ -166,8 +167,11 @@ fun VideoPlayerSurfaceImpl(
  )
  }
 
- // Render the overlay content on top of the video
- overlay()
+ // Render the overlay content on top of the video with fillMaxSize modifier
+ // to ensure it takes the full height of the parent Box
+ Box(modifier = Modifier.fillMaxSize()) {
+ overlay()
+ }
  }
  }
 

mediaplayer/src/jvmMain/kotlin/io/github/kdroidfilter/composemediaplayer/linux/LinuxVideoPlayerSurface.jvm.kt

@@ -2,6 +2,7 @@ package io.github.kdroidfilter.composemediaplayer.linux
 
 import androidx.compose.foundation.Canvas
 import androidx.compose.foundation.layout.Box
+import androidx.compose.foundation.layout.fillMaxSize
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
@@ -83,8 +84,11 @@ fun LinuxVideoPlayerSurface(
  )
  }
 
- // Render the overlay content on top of the video
- overlay()
+ // Render the overlay content on top of the video with fillMaxSize modifier
+ // to ensure it takes the full height of the parent Box
+ Box(modifier = Modifier.fillMaxSize()) {
+ overlay()
+ }
  }
 
  if (playerState.isFullscreen && !isInFullscreenWindow) {

mediaplayer/src/jvmMain/kotlin/io/github/kdroidfilter/composemediaplayer/mac/MacVideoPlayerSurface.kt

@@ -2,6 +2,7 @@ package io.github.kdroidfilter.composemediaplayer.mac
 
 import androidx.compose.foundation.Canvas
 import androidx.compose.foundation.layout.Box
+import androidx.compose.foundation.layout.fillMaxSize
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.remember
@@ -78,8 +79,11 @@ fun MacVideoPlayerSurface(
  }
  }
 
- // Render the overlay content on top of the video
- overlay()
+ // Render the overlay content on top of the video with fillMaxSize modifier
+ // to ensure it takes the full height of the parent Box
+ Box(modifier = Modifier.fillMaxSize()) {
+ overlay()
+ }
  }
 
  if (playerState.isFullscreen && !isInFullscreenWindow) {

mediaplayer/src/jvmMain/kotlin/io/github/kdroidfilter/composemediaplayer/windows/WindowsVideoPlayerSurface.kt

@@ -2,6 +2,7 @@ package io.github.kdroidfilter.composemediaplayer.windows
 
 import androidx.compose.foundation.Canvas
 import androidx.compose.foundation.layout.Box
+import androidx.compose.foundation.layout.fillMaxSize
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.getValue
@@ -93,8 +94,11 @@ fun WindowsVideoPlayerSurface(
  }
  }
 
- // Render the overlay content on top of the video
- overlay()
+ // Render the overlay content on top of the video with fillMaxSize modifier
+ // to ensure it takes the full height of the parent Box
+ Box(modifier = Modifier.fillMaxSize()) {
+ overlay()
+ }
  }
 
  if (playerState.isFullscreen && !isInFullscreenWindow) {

mediaplayer/src/wasmJsMain/kotlin/io/github/kdroidfilter/composemediaplayer/VideoPlayerSurface.wasmjs.kt

@@ -515,7 +515,9 @@ private fun VideoContent(
  .videoRatioClip(videoRatio, contentScale)
  ) {
  SubtitleOverlay(playerState)
- overlay()
+ Box(modifier = Modifier.fillMaxSize()) {
+ overlay()
+ }
  }
  }