DATAJDBC-262 - Update statements no longer set the id column.

Author: schauder

src/main/java/org/springframework/data/jdbc/core/SqlGenerator.java

@@ -284,8 +284,9 @@ private String createUpdateSql() {
 
 String updateTemplate = "UPDATE %s SET %s WHERE %s = :%s";
 
-String setClause = columnNames.stream()//
-.map(n -> String.format("%s = :%s", n, n))//
+String setClause = columnNames.stream() //
+.filter(s -> !s.equals(entity.getIdColumn())) //
+.map(n -> String.format("%s = :%s", n, n)) //
 .collect(Collectors.joining(", "));
 
 return String.format(updateTemplate, entity.getTableName(), setClause, entity.getIdColumn(), entity.getIdColumn());

src/test/java/org/springframework/data/jdbc/core/SqlGeneratorUnitTests.java

@@ -199,6 +199,17 @@ public void joinForOneToOneWithoutIdIncludesTheBackReferenceOfTheOuterJoin() {
 "FROM");
 }
 
+@Test // DATAJDBC-262
+public void update() {
+
+assertThat(sqlGenerator.getUpdate()).containsSequence( //
+"UPDATE", //
+"dummy_entity", //
+"SET", //
+"WHERE", //
+"x_id = :x_id");
+}
+
 private PersistentPropertyPath<RelationalPersistentProperty> getPath(String path, Class<?> base) {
 return PersistentPropertyPathTestUtils.getPath(context, path, base);
 }