Skip to content

Commit 8086425

Browse files
authored
Remove start page-related commands and display logic (microsoft#16791)
* Remove start page related commands * Do not display the start page
1 parent 0a650df commit 8086425

File tree

2 files changed

+0
-34
lines changed

2 files changed

+0
-34
lines changed

package.json

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@
8888
"onCommand:python.switchToDailyChannel",
8989
"onCommand:python.switchToWeeklyChannel",
9090
"onCommand:python.clearWorkspaceInterpreter",
91-
"onCommand:python.startPage.open",
9291
"onCommand:python.enableSourceMapSupport",
9392
"onCommand:python.launchTensorBoard",
9493
"onCommand:python.clearPersistentStorage",
@@ -481,11 +480,6 @@
481480
"command": "python.sortImports",
482481
"title": "%python.command.python.sortImports.title%"
483482
},
484-
{
485-
"category": "Python",
486-
"command": "python.startPage.open",
487-
"title": "%python.command.python.startPage.open.title%"
488-
},
489483
{
490484
"category": "Python",
491485
"command": "python.startREPL",
@@ -1224,12 +1218,6 @@
12241218
"scope": "resource",
12251219
"type": "string"
12261220
},
1227-
"python.showStartPage": {
1228-
"default": true,
1229-
"description": "Show the Python Start Page when a new update is released.",
1230-
"scope": "application",
1231-
"type": "boolean"
1232-
},
12331221
"python.sortImports.args": {
12341222
"default": [],
12351223
"description": "Arguments passed in. Each argument is a separate item in the array.",
@@ -1954,11 +1942,6 @@
19541942
"title": "Run",
19551943
"when": "config.noExists"
19561944
},
1957-
{
1958-
"category": "Python",
1959-
"command": "python.startPage.open",
1960-
"title": "%python.command.python.startPage.open.title%"
1961-
},
19621945
{
19631946
"category": "Python",
19641947
"command": "python.stopTests",

src/client/common/startPage/startPage.ts

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,7 @@ export class StartPage extends WebviewPanelHost<IStartPageMapping>
9090
public async activate(): Promise<void> {
9191
if (this.appEnvironment.uiKind === UIKind.Web) {
9292
// We're running in Codespaces browser-based editor, do not open start page.
93-
return;
9493
}
95-
this.activateBackground().ignoreErrors();
9694
}
9795

9896
public dispose(): Promise<void> {
@@ -301,21 +299,6 @@ export class StartPage extends WebviewPanelHost<IStartPageMapping>
301299
return shouldShowStartPage;
302300
}
303301

304-
private async activateBackground(): Promise<void> {
305-
const settings = this.configuration.getSettings();
306-
307-
if (settings.showStartPage && this.appEnvironment.extensionChannel === 'stable') {
308-
// extesionVersionChanged() reads CHANGELOG.md
309-
// So we use separate if's to try and avoid reading a file every time
310-
const firstTimeOrUpdate = await this.extensionVersionChanged();
311-
312-
if (firstTimeOrUpdate) {
313-
this.firstTime = true;
314-
this.open().ignoreErrors();
315-
}
316-
}
317-
}
318-
319302
// eslint-disable-next-line class-methods-use-this
320303
private savedVersionisOlder(savedVersion: string, actualVersion: string): boolean {
321304
const saved = savedVersion.split('.');

0 commit comments

Comments
 (0)