[src] Fix nnet1 proj-lstm bug where gradient clipping not used; thx:@cbtpkzm (#2696)

Author: danpovey

src/nnet/nnet-lstm-projected.h

@@ -655,21 +655,21 @@ class LstmProjected : public MultistreamComponent {
  const CuMatrixBase<BaseFloat> &diff) {
 
  // apply the gradient clipping,
- if (clip_gradient_ > 0.0) {
- w_gifo_x_corr_.ApplyFloor(-clip_gradient_);
- w_gifo_x_corr_.ApplyCeiling(clip_gradient_);
- w_gifo_r_corr_.ApplyFloor(-clip_gradient_);
- w_gifo_r_corr_.ApplyCeiling(clip_gradient_);
- bias_corr_.ApplyFloor(-clip_gradient_);
- bias_corr_.ApplyCeiling(clip_gradient_);
- w_r_m_corr_.ApplyFloor(-clip_gradient_);
- w_r_m_corr_.ApplyCeiling(clip_gradient_);
- peephole_i_c_corr_.ApplyFloor(-clip_gradient_);
- peephole_i_c_corr_.ApplyCeiling(clip_gradient_);
- peephole_f_c_corr_.ApplyFloor(-clip_gradient_);
- peephole_f_c_corr_.ApplyCeiling(clip_gradient_);
- peephole_o_c_corr_.ApplyFloor(-clip_gradient_);
- peephole_o_c_corr_.ApplyCeiling(clip_gradient_);
+ if (grad_clip_ > 0.0) {
+ w_gifo_x_corr_.ApplyFloor(-grad_clip_);
+ w_gifo_x_corr_.ApplyCeiling(grad_clip_);
+ w_gifo_r_corr_.ApplyFloor(-grad_clip_);
+ w_gifo_r_corr_.ApplyCeiling(grad_clip_);
+ bias_corr_.ApplyFloor(-grad_clip_);
+ bias_corr_.ApplyCeiling(grad_clip_);
+ w_r_m_corr_.ApplyFloor(-grad_clip_);
+ w_r_m_corr_.ApplyCeiling(grad_clip_);
+ peephole_i_c_corr_.ApplyFloor(-grad_clip_);
+ peephole_i_c_corr_.ApplyCeiling(grad_clip_);
+ peephole_f_c_corr_.ApplyFloor(-grad_clip_);
+ peephole_f_c_corr_.ApplyCeiling(grad_clip_);
+ peephole_o_c_corr_.ApplyFloor(-grad_clip_);
+ peephole_o_c_corr_.ApplyCeiling(grad_clip_);
  }
 
  const BaseFloat lr = opts_.learn_rate;
@@ -698,9 +698,6 @@ class LstmProjected : public MultistreamComponent {
  // buffer for transfering state across batches,
  CuMatrix<BaseFloat> prev_nnet_state_;
 
- // gradient-clipping value,
- BaseFloat clip_gradient_;
-
  // feed-forward connections: from x to [g, i, f, o]
  CuMatrix<BaseFloat> w_gifo_x_;
  CuMatrix<BaseFloat> w_gifo_x_corr_;