Fix build failure on github

Author: jahn96

.eslintrc.js

@@ -16,6 +16,7 @@ module.exports = {
  'error',
  { prefixWithI: 'always' }
  ],
+ '@typescript-eslint/camelcase': 'off',
  '@typescript-eslint/no-unused-vars': ['warn', { args: 'none' }],
  '@typescript-eslint/no-explicit-any': 'off',
  '@typescript-eslint/no-namespace': 'off',

src/CodeSnippetDisplay.tsx

@@ -192,33 +192,6 @@ export class CodeSnippetDisplay extends React.Component<
  });
  };
 
- // Pick color for side of snippet box based on number of code lines
- // private codeLinesToColor = (codeSnippet: ICodeSnippet): string => {
- // let color: string;
- // let i,
- // counter = 0;
- // for (i = 0; i < codeSnippet.code[0].length; i++) {
- // if (codeSnippet.code[0][i] === '\n') {
- // counter++;
- // }
- // }
- // if (counter < 25) {
- // color = '8px solid #BBDEFB';
- // } else if (counter >= 25 && counter <= 50) {
- // color = '8px solid #64B5F6';
- // } else {
- // color = '8px solid #1976D2';
- // }
- // return color;
- // };
- //Render snippet bookmark based on state of bookmarked field
- // private bookmarkSnippetRender = (codeSnippet: ICodeSnippet): string => {
- // if(codeSnippet.bookmarked===false) {
- // return "transparent #E5E5E5 transparent transparent";
- // }
- // return "transparent blue transparent transparent";
- // }
-
  //Change bookmark field and color onclick
  private bookmarkSnippetClick = (
  codeSnippet: ICodeSnippet,
@@ -379,53 +352,47 @@ class PreviewHandler extends Widget {
  }
 }
 
-/**
- * A namespace for private data.
- */
-namespace Private {
+class Private {
+ static createPreviewContent(
+ codeSnippet: ICodeSnippet,
+ type: string
+ ): HTMLElement {
+ const body = document.createElement('div');
+ console.log(codeSnippet.code);
+ for (let i = 0; i < codeSnippet.code.length; i++) {
+ const previewContainer = document.createElement('div');
+ const preview = document.createElement('text');
+ preview.contentEditable = 'true';
+
+ if (type === 'code') {
+ previewContainer.className = 'jp-preview-text';
+ preview.className = 'jp-preview-textarea';
+ preview.textContent = codeSnippet.code.join('\n').replace('\n', '\r\n');
+ } else if (type === 'cell') {
+ previewContainer.className = 'jp-preview-cell';
+ const previewPrompt = document.createElement('div');
+ previewPrompt.className = 'jp-preview-cell-prompt';
+ previewPrompt.innerText = '[ ]:';
+ previewContainer.appendChild(previewPrompt);
+ preview.className = 'jp-preview-cellarea';
+ preview.textContent = codeSnippet.code[i];
+ } else {
+ alert('Invalid type to preview');
+ }
+
+ //console.log("this is the text: "+ message.textContent);
+ previewContainer.appendChild(preview);
+ body.append(previewContainer);
+ }
+ return body;
+ }
  /**
  * Create structure for preview of snippet data.
  */
- export function createPreviewNode(
+ static createPreviewNode(
  codeSnippet: ICodeSnippet,
  type: string
  ): HTMLElement {
- //let code:string = codeSnippet.code[0];
-
- return createPreviewContent(codeSnippet, type);
- }
-}
-
-function createPreviewContent(
- codeSnippet: ICodeSnippet,
- type: string
-): HTMLElement {
- const body = document.createElement('div');
- console.log(codeSnippet.code);
- for (let i = 0; i < codeSnippet.code.length; i++) {
- const previewContainer = document.createElement('div');
- const preview = document.createElement('text');
- preview.contentEditable = 'true';
-
- if (type === 'code') {
- previewContainer.className = 'jp-preview-text';
- preview.className = 'jp-preview-textarea';
- preview.textContent = codeSnippet.code.join('\n').replace('\n', '\r\n');
- } else if (type === 'cell') {
- previewContainer.className = 'jp-preview-cell';
- const previewPrompt = document.createElement('div');
- previewPrompt.className = 'jp-preview-cell-prompt';
- previewPrompt.innerText = '[ ]:';
- previewContainer.appendChild(previewPrompt);
- preview.className = 'jp-preview-cellarea';
- preview.textContent = codeSnippet.code[i];
- } else {
- alert('Invalid type to preview');
- }
-
- //console.log("this is the text: "+ message.textContent);
- previewContainer.appendChild(preview);
- body.append(previewContainer);
+ return this.createPreviewContent(codeSnippet, type);
  }
- return body;
 }

src/CodeSnippetForm.ts

@@ -176,7 +176,7 @@ export function shouldOverwrite(path: string): Promise<boolean> {
  * Disallows "/", "\", and ":" in file names, as well as names with zero length.
  */
 export function isValidFileName(name: string): boolean {
- const validNameExp = /[\/\\:]/;
+ const validNameExp = /[/\\:]/;
  return name.length > 0 && !validNameExp.test(name);
 }
 
@@ -185,10 +185,10 @@ export function isValidFileName(name: string): boolean {
  */
 export function validateForm(input: Dialog.IResult<string[]>): boolean {
  let status = true;
- let message: string = '';
- let name = input.value[0];
- let description = input.value[1];
- let language = input.value[2];
+ let message = '';
+ const name = input.value[0];
+ const description = input.value[1];
+ const language = input.value[2];
  if (name === '') {
  message += 'Name must be filled out\n';
  //alert("Description must be filled out");
@@ -204,7 +204,7 @@ export function validateForm(input: Dialog.IResult<string[]>): boolean {
  //alert("Description ");
  status = false;
  }
- if (status == false) {
+ if (status === false) {
  alert(message);
  }
  return status;
@@ -223,7 +223,7 @@ class InputHandler extends Widget {
  }
 
  getValue(): string[] {
- let inputs = [];
+ const inputs = [];
  inputs.push(
  (this.node.getElementsByTagName('input')[0] as HTMLInputElement).value,
  (this.node.getElementsByTagName('input')[1] as HTMLInputElement).value,
@@ -242,11 +242,11 @@ class MessageHandler extends Widget {
 /**
  * A namespace for private data.
  */
-namespace Private {
+class Private {
  /**
  * Create the node for a rename handler. This is what's creating all of the elements to be displayed.
  */
- export function createInputNode(): HTMLElement {
+ static createInputNode(): HTMLElement {
  const body = document.createElement('form');
 
  const nameTitle = document.createElement('label');
@@ -274,7 +274,7 @@ namespace Private {
  return body;
  }
 
- export function createConfirmMessageNode(): HTMLElement {
+ static createConfirmMessageNode(): HTMLElement {
  const body = document.createElement('div');
  body.innerHTML = checkSVGstr;
 

src/CodeSnippetWidget.tsx

@@ -460,11 +460,11 @@ export namespace CodeSnippetWidget {
  }
 }
 
-namespace Private {
+class Private {
  /**
  * Given a MimeData instance, extract the data, if any.
  */
- export function findCellData(mime: MimeData): string[] {
+ static findCellData(mime: MimeData): string[] {
  // const types = mime.types();
  // console.log(types);
  // application/vnd.jupyter.cells

src/CodeSnippetWidgetModel.ts

@@ -31,19 +31,19 @@ export class CodeSnippetWidgetModel implements ICodeSnippetWidgetModel {
  return this._snippets.snippets;
  }
 
- addSnippet(snippetOpt: CodeSnippetModel.IOptions, index: number) {
- if (snippetOpt.id == -1) {
+ addSnippet(snippetOpt: CodeSnippetModel.IOptions, index: number): void {
+ if (snippetOpt.id === -1) {
  snippetOpt.id = this.snippets.length;
  }
  const newSnippet = this.contentFactory.createSnippet(snippetOpt);
  this._snippets.insertSnippet(newSnippet, index);
  }
 
- sortSnippets() {
+ sortSnippets(): void {
  this._snippets.sort();
  }
 
- deleteSnippet(index: number) {
+ deleteSnippet(index: number): void {
  this._snippets.deleteSnippet(index);
  }
 }
@@ -71,7 +71,7 @@ export namespace CodeSnippetWidgetModel {
  }
 
  export class ContentFactory implements IContentFactory {
- createSnippet(options: CodeSnippetModel.IOptions) {
+ createSnippet(options: CodeSnippetModel.IOptions): CodeSnippetModel {
  return new CodeSnippetModel(options);
  }
  }

src/CodeSnippetWrapper.ts

@@ -34,7 +34,7 @@ export class CodeSnippetWrapper extends Widget {
  /**
  * Create a code snippet widget
  */
- createCodeSnippetWidget(codeSnippets: ICodeSnippet[]) {
+ createCodeSnippetWidget(codeSnippets: ICodeSnippet[]): void {
  const layout = this.layout as PanelLayout;
  const codeSnippetWidget = CodeSnippetWidget.getInstance(
  codeSnippets,

src/ConfirmMessage.tsx

@@ -347,7 +347,7 @@ export namespace ConfirmMessage {
  * The dialog widget tracker.
  */
  export const tracker = new WidgetTracker<ConfirmMessage<any>>({
- namespace: '@jupyterlab/code_snippet:ConfirmWidget',
+ namespace: '@jupyterlab/code_snippet:ConfirmWidget'
  });
 }
 

src/PreviewSnippet.tsx

@@ -56,7 +56,7 @@ export class Preview<T> extends Widget {
  content.addWidget(body);
 
  if (Preview.tracker.size > 0) {
- let previous = Preview.tracker.currentWidget;
+ const previous = Preview.tracker.currentWidget;
  if (previous._title === this._title) {
  this.ready = false;
  }

src/SearchBar.tsx

@@ -10,15 +10,15 @@ export class SearchBar extends React.Component<ISearchProp> {
  value: ''
  };
 
- updateValue = (event: React.ChangeEvent<HTMLInputElement>) => {
+ updateValue = (event: React.ChangeEvent<HTMLInputElement>): void => {
  this.setState({ value: event.target.value }, this.filterSnippets);
  };
 
- filterSnippets = () => {
+ filterSnippets = (): void => {
  this.props.onFilter(this.state.value);
  };
 
- render() {
+ render(): JSX.Element {
  return (
  <div className="jp-codesnippet-searchbar">
  <InputGroup

src/SnippetList.ts

@@ -51,7 +51,7 @@ export class SnippetList {
  return snippetList;
  }
 
- sort() {
+ sort(): void {
  this.snippetList.sort((a, b) => a.id - b.id);
  }
 
@@ -60,7 +60,7 @@ export class SnippetList {
  * @param newSnippet new snippet to insert
  * @param index index to insert. If it's not given, the snippet is added at the end of the list.
  */
- insertSnippet(newSnippet: ICodeSnippetModel, index: number = -1) {
+ insertSnippet(newSnippet: ICodeSnippetModel, index = -1): void {
  const numSnippets = this.snippetList.length;
 
  // add it at the end of the list
@@ -86,7 +86,7 @@ export class SnippetList {
  * Delete a snippet from the list
  * @param index index to delete. If it's not given, the last one gets deleted.
  */
- deleteSnippet(index: number = -1) {
+ deleteSnippet(index = -1): void {
  const numSnippets = this.snippetList.length;
  if (index < 0 || index > numSnippets) {
  this.snippetList.pop();