@@ -271,19 +271,13 @@ class PlainGeometry(Geometry):
271271 _view_name = Unicode ('PlainGeometryView' ).tag (sync = True )
272272 _model_name = Unicode ('PlainGeometryModel' ).tag (sync = True )
273273
274- # TODO: vertices: numpy shape (*, 3), dtype float32
275274 vertices = Array (dtype = 'float32' ).tag (sync = True , ** array_serialization ).valid (shape_constraints (None ,3 ))
276275 faces = Array (dtype = 'uint32' , default_value = np .empty (shape = (0 ,3 ), dtype = 'uint32' )).tag (sync = True , ** array_serialization ).valid (shape_constraints (None ,3 ))
276+
277277 # list of [[v1_r,v1_g,v1_b], [v2_r,v2_g,v2_b], [v3_r,v3_g,v3_b]] for each face
278278 faceColors = Array (dtype = 'float32' , default_value = np .empty (shape = (0 ,3 ,3 ), dtype = 'float32' )).tag (sync = True , ** array_serialization ).valid (shape_constraints (None , 3 , 3 ))
279- #vertices = List(vector3(CFloat)).tag(sync=True)
280279 colors = List (Color ).tag (sync = True )
281- #faces = List(List(CFloat)).tag(sync=True)
282- # TODO: type this better. Can handle lists of string colors, or lists of lists of string colors.
283- #faceColors = Tuple().tag(sync=True)
284- # TODO: type this better. Can handle lists of vector3(CFloat), or lists of lists of vector3(CFloat).
285280 faceNormals = Tuple ().tag (sync = True )
286- # todo: faceVertexUvs = List(vector3(vector2(CFloat))).tag(sync=True)
287281
288282class PlainBufferGeometry (Geometry ):
289283 _view_name = Unicode ('PlainBufferGeometryView' ).tag (sync = True )
0 commit comments