Skip to content

Stop crashing on undefined or null properties in flow intersection #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2018
Merged

Stop crashing on undefined or null properties in flow intersection #1860

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71b522a
Stop crashing on undefined or null properties
nicholas-l Jun 28, 2018
704f5d9
Merge branch 'master' into patch-1
nicholas-l Jul 4, 2018
87a0818
Add test cases
nicholas-l Jul 4, 2018
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rules/prop-types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ module.exports = {
and property value. (key, value) => void
*/
function iterateProperties(properties, fn) {
if (properties.length && typeof fn === 'function') {
if (properties && properties.length && typeof fn === 'function') {
for (let i = 0, j = properties.length; i < j; i++) {
const node = properties[i];
const key = getKeyValue(node);
Expand Down