[Bug]: jsx-newline sometimes breaks with comments #3573
Description
Is there an existing issue for this?
- I have searched the existing issues and my issue is unique
- My issue appears in the command-line and not only in the text editor
Description Overview
In the following minimal example, the react/jsx-newline rule fails to parse the file:
function Test() { return ( <div> <div /> {/* a comment */} </div> ); }The following error is printed on running eslint:
Oops! Something went wrong! :( ESLint: 8.40.0 TypeError: Cannot read properties of undefined (reading 'loc') Occurred while linting /home/happens/tmp/jsx-newline-test/test.jsx:1 Rule: "react/jsx-newline" at isMultilined (/home/happens/tmp/jsx-newline-test/node_modules/eslint-plugin-react/lib/rules/jsx-newline.js:23:15) at /home/happens/tmp/jsx-newline-test/node_modules/eslint-plugin-react/lib/rules/jsx-newline.js:111:22 at Array.forEach (<anonymous>) at /home/happens/tmp/jsx-newline-test/node_modules/eslint-plugin-react/lib/rules/jsx-newline.js:87:27 at Set.forEach (<anonymous>) at Program:exit (/home/happens/tmp/jsx-newline-test/node_modules/eslint-plugin-react/lib/rules/jsx-newline.js:86:27) at ruleErrorHandler (/home/happens/tmp/jsx-newline-test/node_modules/eslint/lib/linter/linter.js:1049:28) at /home/happens/tmp/jsx-newline-test/node_modules/eslint/lib/linter/safe-emitter.js:45:58 at Array.forEach (<anonymous>) at Object.emit (/home/happens/tmp/jsx-newline-test/node_modules/eslint/lib/linter/safe-emitter.js:45:38) Moving the comment up a row or removing the sibling fixes the problem.
Expected Behavior
The rule should be able to correctly parse the file.
eslint-plugin-react version
v7.32.2
eslint version
v8.40.0
node version
v19.9.0