fixup! [New] Symmetric useState hook variable names

Author: duncanbeevers

lib/rules/hook-use-state.js

@@ -32,24 +32,24 @@ module.exports = {
  },
 
  create(context) {
- let isReactImported = false;
- let reactUseStateLocal;
+ let reactImportLocalName;
+ let reactUseStateLocalName;
 
  return {
  CallExpression(node) {
  const isReactUseStateCall = (
- isReactImported
+ reactImportLocalName
  && node.callee.type === 'MemberExpression'
  && node.callee.object.type === 'Identifier'
- && node.callee.object.name === 'React'
+ && node.callee.object.name === reactImportLocalName
  && node.callee.property.type === 'Identifier'
  && node.callee.property.name === 'useState'
  );
 
  const isUseStateCall = (
- reactUseStateLocal
+ reactUseStateLocalName
  && node.callee.type === 'Identifier'
- && node.callee.name === reactUseStateLocal
+ && node.callee.name === reactUseStateLocalName
  );
 
  // Ignore unless this is a useState() or React.useState() call.
@@ -102,7 +102,10 @@ module.exports = {
  }
  },
  ImportDeclaration(node) {
- isReactImported = node.source.type === 'Literal' && node.source.value === 'react';
+ const isReactImported = node.source.type === 'Literal' && node.source.value === 'react';
+ const reactDefaultSpecifier = node.specifiers.find((specifier) => specifier.type === 'ImportDefaultSpecifier');
+ reactImportLocalName = reactDefaultSpecifier ? reactDefaultSpecifier.local.name : undefined;
+
  const reactUseStateSpecifier = isReactImported
  ? node.specifiers.find(
  (specifier) => (
@@ -112,7 +115,7 @@ module.exports = {
  )
  : undefined;
 
- reactUseStateLocal = reactUseStateSpecifier
+ reactUseStateLocalName = reactUseStateSpecifier
  ? reactUseStateSpecifier.local.name
  : undefined;
  }

tests/lib/rules/hook-use-state.js

@@ -91,15 +91,22 @@ const tests = {
  }]
  },
  {
- code: `import { useState } from 'react';
- const result = useState()`,
+ code: `import React from 'react';
+ const result = React.useState()`,
+ errors: [{
+ message: 'setState call is not destructured into value + setter pair'
+ }]
+ },
+ {
+ code: `import ReactAlternative from 'react';
+ ReactAlternative.useState()`,
  errors: [{
  message: 'setState call is not destructured into value + setter pair'
  }]
  },
  {
  code: `import { useState } from 'react';
- const result = React.useState()`,
+ const result = useState()`,
  errors: [{
  message: 'setState call is not destructured into value + setter pair'
  }]