Skip to content

Conversation

@MichaelDeBoey
Copy link
Contributor

Same reason as mentioned in #1030: *.keys() & *.entries() is an array, so no need to spread them anymore

Co-authored-by: v1rtl <hi@v1rtl.site> Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@ljharb
Copy link
Member

ljharb commented Oct 25, 2024

I pulled this into the branch as 0298c54 - i think this could probably be closed?

(although what would be much better is rebasing it onto main so 0298c54 can be landed there - if you don't feel like doing it, though, i'll do so)

@MichaelDeBoey MichaelDeBoey force-pushed the dont-spread-arrays branch 2 times, most recently from 3f72e2c to be25c7c Compare October 25, 2024 23:25
@MichaelDeBoey
Copy link
Contributor Author

although what would be much better is rebasing it onto main so it can be landed there

That could cause errors as Object.* is probably not fully supported in Node 4 yet 🤔

@ljharb
Copy link
Member

ljharb commented Oct 25, 2024

This PR is about not spreading *-query arrays, though, not about destructuring builtins.

@MichaelDeBoey MichaelDeBoey requested a review from ljharb October 25, 2024 23:26
@MichaelDeBoey
Copy link
Contributor Author

Oops, I mixed them up as I was rebasing both PRs 🙈

Rebasing this to main would be a pain to resolve conflicts, so I'd rather keep this at breaking tbh

@ljharb ljharb changed the base branch from breaking to main October 25, 2024 23:38
@ljharb
Copy link
Member

ljharb commented Oct 25, 2024

No worries, I've done it :-) thanks!

@ljharb ljharb force-pushed the dont-spread-arrays branch from be25c7c to d15d3ab Compare October 25, 2024 23:39
@ljharb ljharb merged commit d15d3ab into jsx-eslint:main Oct 26, 2024
112 checks passed
@MichaelDeBoey MichaelDeBoey deleted the dont-spread-arrays branch October 26, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants